From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?C=E9lestin_Matte?= Subject: Re: [PATCH v3 07/28] git-remote-mediawiki: Rewrite unclear line of instructions Date: Tue, 11 Jun 2013 22:13:28 +0200 Message-ID: <51B784E8.8020700@ensimag.fr> References: <1370816573-3808-1-git-send-email-celestin.matte@ensimag.fr> <1370816573-3808-8-git-send-email-celestin.matte@ensimag.fr> <7vsj0od6z5.fsf@alter.siamese.dyndns.org> <7vhah4bjtf.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Matthieu Moy , =?ISO-8859-1?Q?C=E9lesti?= =?ISO-8859-1?Q?n_Matte?= , git@vger.kernel.org, benoit.person@ensimag.fr To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Jun 11 22:13:55 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UmUx0-00036F-Ug for gcvg-git-2@plane.gmane.org; Tue, 11 Jun 2013 22:13:55 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757003Ab3FKUNi convert rfc822-to-quoted-printable (ORCPT ); Tue, 11 Jun 2013 16:13:38 -0400 Received: from mx1.imag.fr ([129.88.30.5]:45868 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757075Ab3FKUNh (ORCPT ); Tue, 11 Jun 2013 16:13:37 -0400 Received: from ensimag.imag.fr (ensimag.imag.fr [195.221.228.12]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id r5BKDOpb001850 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Jun 2013 22:13:24 +0200 Received: from ensibm.imag.fr (ensibm.imag.fr [195.221.228.8]) by ensimag.imag.fr (8.13.8/8.13.8/ImagV2.1.r_ens) with ESMTP id r5BKDRbw023131; Tue, 11 Jun 2013 22:13:27 +0200 Received: from [127.0.0.1] (ensibm [195.221.228.8]) by ensibm.imag.fr (8.13.8/8.13.8/ImagV2.1.sb_ens.pm) with ESMTP id r5BKDQ6t003063; Tue, 11 Jun 2013 22:13:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 In-Reply-To: <7vhah4bjtf.fsf@alter.siamese.dyndns.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Tue, 11 Jun 2013 22:13:25 +0200 (CEST) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Le 11/06/2013 20:09, Junio C Hamano a =E9crit : > Matthieu Moy writes: >=20 >>> my ($namespace) =3D @_; >>> my $namespace =3D shift; >>> >>> My impression has been that both are equally common, >> >> The second is the most common in git-remote-mediawiki (but I don't h= ave >> any preference nor know what is recommended elsewhere). >=20 > I wasn't implying I prefer the former. I was just being curious, > and if the latter is more prevalent in the code _and_ Perlcritique > does not have any issue with it, it is perfectly fine. Perlcritic doesn't have an issue with any of both cases. I think the second method is clearer when there is only one argument, because it makes it clear that there is only one. --=20 C=E9lestin Matte