From: "Célestin Matte" <celestin.matte@ensimag.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, benoit.person@ensimag.fr,
matthieu.moy@grenoble-inp.fr
Subject: Re: [PATCH 17/18] Place the open() call inside the do{} struct and prevent failing close
Date: Fri, 07 Jun 2013 00:16:55 +0200 [thread overview]
Message-ID: <51B10A57.6060900@ensimag.fr> (raw)
In-Reply-To: <7vbo7iyk8e.fsf@alter.siamese.dyndns.org>
Le 06/06/2013 23:58, Junio C Hamano a écrit :
> Célestin Matte <celestin.matte@ensimag.fr> writes:
>
>> So using autodie may not be a good idea.
>> But the problem is that in the current state, open() return values are
>> checked, but print ones are not, although it should be.
>
> I tried "man autodie" and tried to spot 'print' in the categories
> list that shows things like ":all covers :default which in turn
> covers :io which in turn covers read, seek, ..." and didn't see any.
>
> Running the attached as
>
> $ perl ad.perl >&-
>
> gave me "Hi" (i.e. no failure from print) but of course killed a
> failing syswrite().
You're right, print is not in the list of function checked by autodie.
> So I am not sure your "we must check print" matches well with use of
> autodie, either.
So I'm not sure what we should do for print calls: should we
systematically check them all? That would be a painful and less-readable
thing to do. We may just not bother about it, after all...
next prev parent reply other threads:[~2013-06-06 22:18 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 19:34 [PATCH 00/18] git-remote-mediawiki: Follow perlcritic's recommandations Célestin Matte
2013-06-06 19:34 ` [PATCH 01/18] Follow perlcritic's recommendations - level 5 and 4 Célestin Matte
2013-06-07 1:42 ` Eric Sunshine
2013-06-07 8:10 ` Matthieu Moy
2013-06-07 12:11 ` Célestin Matte
2013-06-07 17:43 ` Matthieu Moy
2013-06-06 19:34 ` [PATCH 02/18] Change style of some regular expressions to make them clearer Célestin Matte
2013-06-07 1:54 ` Eric Sunshine
2013-06-07 2:30 ` Junio C Hamano
2013-06-07 4:39 ` Eric Sunshine
2013-06-07 4:51 ` Junio C Hamano
2013-06-07 10:40 ` Peter Krefting
2013-06-06 19:34 ` [PATCH 03/18] Add newline in the end of die() error messages Célestin Matte
2013-06-06 19:34 ` [PATCH 04/18] Prevent local variable $url to have the same name as a global variable Célestin Matte
2013-06-06 19:34 ` [PATCH 05/18] Turn double-negated expressions into simple expressions Célestin Matte
2013-06-07 4:12 ` Eric Sunshine
2013-06-07 17:04 ` Célestin Matte
2013-06-07 20:25 ` Eric Sunshine
2013-06-07 20:32 ` Célestin Matte
2013-06-06 19:34 ` [PATCH 06/18] Remove unused variable Célestin Matte
2013-06-06 19:34 ` [PATCH 07/18] Rename a variable ($last) so that it does not have the name of a keyword Célestin Matte
2013-06-06 19:34 ` [PATCH 08/18] Explicitely assign local variable as undef and make a proper one-instruction-by- line indentation Célestin Matte
2013-06-07 1:19 ` Eric Sunshine
2013-06-07 8:18 ` Matthieu Moy
2013-06-06 19:34 ` [PATCH 09/18] Check return value of open and remove import of unused open2 Célestin Matte
2013-06-07 8:21 ` Matthieu Moy
2013-06-06 19:34 ` [PATCH 10/18] Put long code into a submodule Célestin Matte
2013-06-07 4:01 ` Eric Sunshine
2013-06-07 4:51 ` Junio C Hamano
2013-06-06 19:34 ` [PATCH 11/18] Modify strings for a better coding-style Célestin Matte
2013-06-07 4:31 ` Eric Sunshine
2013-06-06 19:34 ` [PATCH 12/18] Brace file handles for print for more clarity Célestin Matte
2013-06-06 19:34 ` [PATCH 13/18] Remove "unless" statements and replace them by negated "if" statements Célestin Matte
2013-06-07 3:41 ` Eric Sunshine
2013-06-06 19:34 ` [PATCH 14/18] Don't use quotes for empty strings Célestin Matte
2013-06-06 19:34 ` [PATCH 15/18] Put non-trivial numeric values (e.g., different from 0, 1 and 2) in constants Célestin Matte
2013-06-06 19:34 ` [PATCH 16/18] Fix a typo ("mediwiki" instead of "mediawiki") Célestin Matte
2013-06-06 19:34 ` [PATCH 17/18] Place the open() call inside the do{} struct and prevent failing close Célestin Matte
2013-06-06 21:13 ` Junio C Hamano
2013-06-06 21:30 ` Célestin Matte
2013-06-06 21:58 ` Junio C Hamano
2013-06-06 22:16 ` Célestin Matte [this message]
2013-06-06 19:34 ` [PATCH 18/18] Clearly rewrite double dereference Célestin Matte
2013-06-07 4:04 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B10A57.6060900@ensimag.fr \
--to=celestin.matte@ensimag.fr \
--cc=benoit.person@ensimag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthieu.moy@grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).