From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Junio C Hamano <gitster@pobox.com>, Adam Dinwoodie <adam@dinwoodie.org>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Test failure for v2.16.0-rc0 on cygwin
Date: Sat, 30 Dec 2017 14:21:23 +0000 [thread overview]
Message-ID: <519ac918-6b5f-bca3-05a0-0114683b9724@ramsayjones.plus.com> (raw)
Hi Junio, Adam,
Just a quick note about the failure of the test-suite on cygwin.
In particular, test t5580-clone-push-unc.sh #3, like so:
$ ./t5580-clone-push-unc.sh -i -v
...
ok 2 - clone
expecting success:
(
cd clone &&
git checkout -b to-push &&
test_commit to-push &&
git push origin HEAD
) &&
rev="$(git -C clone rev-parse --verify refs/heads/to-push)" &&
test "$rev" = "$(git rev-parse --verify refs/heads/to-push)"
Switched to a new branch 'to-push'
[to-push 0adccbe] to-push
Author: A U Thor <author@example.com>
1 file changed, 1 insertion(+)
create mode 100644 to-push.t
Counting objects: 3, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 289 bytes | 289.00 KiB/s, done.
Total 3 (delta 0), reused 0 (delta 0)
error: remote unpack failed: unable to create temporary object directory
To file:////localhost/C$/\cygwin64\home\ramsay\git\t\trash directory.t5580-clone-push-unc
! [remote rejected] HEAD -> to-push (unpacker error)
error: failed to push some refs to 'file:////localhost/C$/\cygwin64\home\ramsay\git\t\trash directory.t5580-clone-push-unc'
not ok 3 - push
#
# (
# cd clone &&
# git checkout -b to-push &&
# test_commit to-push &&
# git push origin HEAD
# ) &&
# rev="$(git -C clone rev-parse --verify refs/heads/to-push)" &&
# test "$rev" = "$(git rev-parse --verify refs/heads/to-push)"
#
$
My first, knee-jerk, reaction on seeing the backslashes in the 'local' part
of the pathname (despite what it says in commit f21d60b429) was to replace
the 'cygpath -aw .' with 'cygpath -am .'. This leads to exactly the same
error display as above, except '\\' replaced by '/' in the pathname! Hmm.
Note:
$ ls '//localhost/C$/\cygwin64\home\ramsay\git\t\trash directory.t5580-clone-push-unc'
clone/ initial.t
$ ls '//localhost/C$//cygwin64/home/ramsay/git/t/trash directory.t5580-clone-push-unc'
clone/ initial.t
$ ls //localhost/C$/\\cygwin64\\home\\ramsay\\git\\t\\trash\ directory.t5580-clone-push-unc
clone/ initial.t
$
So, after some debugging (using the 'cygpath -am .' version), it seems that
the error message is caused by the mkdtemp() call in tmp_objdir_create()
function (tmp-objdir.c:123), failing with an errno of 'permission denied'.
At the time of the call to mkdtemp, the current working directory is given by
'//localhost/C$/cygwin64/home/ramsay/git/t/trash directory.t5580-clone-push-unc/.git',
and the parameter to mkdtemp is (for example) "./objects/incoming-MgZCkI".
$ cd trash\ directory.t5580-clone-push-unc/
$ ls
clone/ initial.t
$ ls .git
branches/ config HEAD index logs/ refs/
COMMIT_EDITMSG description hooks-disabled/ info/ objects/
$ ls .git/objects
24/ 93/ e7/ info/ pack/
$ mkdir '//localhost/C$//cygwin64/home/ramsay/git/t/trash directory.t5580-clone-push-unc/.git/./objects/incoming-MgZCkI'
mkdir: cannot create directory ‘//localhost/C$//cygwin64/home/ramsay/git/t/trash directory.t5580-clone-push-unc/.git/./objects/incoming-MgZCkI’: Permission denied
$
So, when 'doing it by hand', I get the same result. ;-)
Looking at the permissions:
$ ls -ld '//localhost/C$//cygwin64/home/ramsay/git/t/trash directory.t5580-clone-push-unc/.git/./objects'
drwxr-xr-x+ 1 ramsay None 0 Dec 30 13:51 '//localhost/C$//cygwin64/home/ramsay/git/t/trash directory.t5580-clone-push-unc/.git/./objects'/
$ ls -ld '//localhost/C$//cygwin64/home/ramsay/git/t/trash directory.t5580-clone-push-unc/.git'
drwxr-xr-x+ 1 ramsay None 0 Dec 30 13:51 '//localhost/C$//cygwin64/home/ramsay/git/t/trash directory.t5580-clone-push-unc/.git'/
$ ls -ld '//localhost/C$//cygwin64/home/ramsay/git/t/trash directory.t5580-clone-push-unc'
drwxr-xr-x+ 1 ramsay None 0 Dec 30 13:51 '//localhost/C$//cygwin64/home/ramsay/git/t/trash directory.t5580-clone-push-unc'/
... and so on, until:
$ ls -ld '//localhost/C$'
d---r-x---+ 1 TrustedInstaller TrustedInstaller 0 Oct 28 16:16 '//localhost/C$'/
$
Doing a quick web-search on '//localhost/C$' lead me to several posts which
seem to suggest the problem could be related to UAC filtering on remote
shares (and the fact that I am on Windows 10), along with a registry setting
for 'LocalAccountTokenFilterPolicy'. However, I have not had time to look
into any of that.
Adam, are you running the tests on Windows 10?
I have to go now, so I can't look at this further today. Just FYI.
ATB,
Ramsay Jones
next reply other threads:[~2017-12-30 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 14:21 Ramsay Jones [this message]
2017-12-30 14:40 ` Test failure for v2.16.0-rc0 on cygwin Adam Dinwoodie
2018-01-02 11:36 ` Adam Dinwoodie
2018-01-02 15:32 ` Ramsay Jones
2018-01-02 19:34 ` Ramsay Jones
2018-01-04 20:55 ` Johannes Schindelin
2018-01-10 23:17 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519ac918-6b5f-bca3-05a0-0114683b9724@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).