From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 5F3E61F5AE for ; Mon, 10 May 2021 09:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230373AbhEJJpi (ORCPT ); Mon, 10 May 2021 05:45:38 -0400 Received: from smtp505.hk.chengmail.me ([113.10.190.62]:54276 "EHLO smtp505.hk.chengmail.me" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbhEJJph (ORCPT ); Mon, 10 May 2021 05:45:37 -0400 X-CHENGMAILHOST: 113.10.190.62 X-CHENGMAIL-INSTANCEID: 59a4.60990079.c6c1f.0 From: lilinchao@oschina.cn To: git@vger.kernel.org Cc: dstolee@microsoft.com, gitster@pobox.com, Li Linchao Subject: [PATCH] builtin/gc: warn when core.commitGraph is disabled Date: Mon, 10 May 2021 17:43:43 +0800 X-source-message-id: <20210510094343.28340-1-lilinchao@oschina.cn> X-Mailer: git-send-email 2.31.1.442.g7e39198978 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID: <510425b8b17411eb93770026b95c99cc@oschina.cn> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Li Linchao Throw warning message when core.commitGraph is disabled in commit-graph maintenance task. Signed-off-by: Li Linchao --- builtin/gc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/builtin/gc.c b/builtin/gc.c index 98a803196b..90684ca3b3 100644 --- a/builtin/gc.c +++ b/builtin/gc.c @@ -861,8 +861,10 @@ static int run_write_commit_graph(struct maintenance_run_opts *opts) static int maintenance_task_commit_graph(struct maintenance_run_opts *opts) { prepare_repo_settings(the_repository); - if (!the_repository->settings.core_commit_graph) + if (!the_repository->settings.core_commit_graph) { + warning(_("skipping commit-graph task because core.commitGraph is disabled")); return 0; + } close_object_store(the_repository->objects); if (run_write_commit_graph(opts)) { -- 2.31.1.442.g7e39198978