From: Derrick Stolee <stolee@gmail.com>
To: mhagger@alum.mit.edu, Christian Couder <christian.couder@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Stefan Beller" <sbeller@google.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Jonathan Tan" <jonathantanmy@google.com>,
"Duy Nguyen" <pclouds@gmail.com>,
"Carlos Martín Nieto" <cmn@dwim.me>,
"David Turner" <novalis@novalis.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Christian Couder" <chriscool@tuxfamily.org>,
"David Turner" <dturner@twopensource.com>
Subject: Re: [PATCH] t990X: use '.git/objects' as 'deep inside .git' path
Date: Tue, 29 May 2018 07:58:03 -0400 [thread overview]
Message-ID: <50c85752-7000-880e-ebfd-44b8e7f71028@gmail.com> (raw)
In-Reply-To: <CAMy9T_H7OVJoDQGFNnM-GrCE9jhSqNDALFL1TM45TMcwPx5nnQ@mail.gmail.com>
On 5/27/2018 12:49 AM, Michael Haggerty wrote:
> On Sat, May 26, 2018 at 8:47 AM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> Tests t9902-completion.sh and t9903-bash-prompt.sh each have tests
>> that check what happens when we are "in the '.git' directory" and
>> when we are "deep inside the '.git' directory".
>>
>> To test the case when we are "deep inside the '.git' directory" the
>> test scripts used to perform a `cd .git/refs/heads`.
>>
>> As there are plans to implement other ref storage systems, let's
>> use '.git/objects' instead of '.git/refs/heads' as the "deep inside
>> the '.git' directory" path.
> Seems reasonable to me. +1.
>
> Michael
Looks good to me, too.
Thanks,
-Stolee
prev parent reply other threads:[~2018-05-29 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-26 6:47 [PATCH] t990X: use '.git/objects' as 'deep inside .git' path Christian Couder
2018-05-27 4:49 ` Michael Haggerty
2018-05-29 11:58 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50c85752-7000-880e-ebfd-44b8e7f71028@gmail.com \
--to=stolee@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=cmn@dwim.me \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=novalis@novalis.org \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).