From: "Torsten Bögershausen" <tboegi@web.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Jean-Noël AVILA" <avila.jn@gmail.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Jeff King" <peff@peff.net>, "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>
Subject: Re: t9902 fails (Was: [PATCH] attr: fix off-by-one directory component length calculation)
Date: Fri, 18 Jan 2013 06:20:59 +0100 [thread overview]
Message-ID: <50F8DBBB.7040005@web.de> (raw)
In-Reply-To: <20130118000454.GI13449@google.com>
On 18.01.13 01:04, Jonathan Nieder wrote:
> Jean-Noël AVILA wrote:
>
>> OK. I have installed practically everything related to git from the package
>> manager and there is a git-checkout-branches utility available.
>>
>> That result defeats the purpose of the test. This needs a tighter environment
>> to work whatever the configuration of the user may be.
> Presumably 'git checkout-branches' is from git-stuff.
>
> Here's a patch to make the tested command a little less likely to
> conflict with commands from the user's $PATH. I'm not thrilled with
> it because the contents of $PATH are still not tightly controlled, and
> this does nothing to avoid problems due to existence of, for example,
> a "git cherry-pick-branches" command.
>
> Thoughts? Maybe it would be enough to check that the intended get
> commands are present in the completion list and other git commands are
> not, ignoring binaries that might live elsewhere on the $PATH?
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> t/t9902-completion.sh | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
> index 3cd53f8..06dcfb2 100755
> --- a/t/t9902-completion.sh
> +++ b/t/t9902-completion.sh
> @@ -192,19 +192,19 @@ test_expect_success 'general options' '
> '
>
> test_expect_success 'general options plus command' '
> - test_completion "git --version check" "checkout " &&
> - test_completion "git --paginate check" "checkout " &&
> - test_completion "git --git-dir=foo check" "checkout " &&
> - test_completion "git --bare check" "checkout " &&
> - test_completion "git --help des" "describe " &&
> - test_completion "git --exec-path=foo check" "checkout " &&
> - test_completion "git --html-path check" "checkout " &&
> - test_completion "git --no-pager check" "checkout " &&
> - test_completion "git --work-tree=foo check" "checkout " &&
> - test_completion "git --namespace=foo check" "checkout " &&
> - test_completion "git --paginate check" "checkout " &&
> - test_completion "git --info-path check" "checkout " &&
> - test_completion "git --no-replace-objects check" "checkout "
> + test_completion "git --version cherry-p" "cherry-pick " &&
> + test_completion "git --paginate cherry-p" "cherry-pick " &&
> + test_completion "git --git-dir=foo cherry-p" "cherry-pick " &&
> + test_completion "git --bare cherry-p" "cherry-pick " &&
> + test_completion "git --help cherry-p" "cherry-pick " &&
> + test_completion "git --exec-path=foo cherry-p" "cherry-pick " &&
> + test_completion "git --html-path cherry-p" "cherry-pick " &&
> + test_completion "git --no-pager cherry-p" "cherry-pick " &&
> + test_completion "git --work-tree=foo cherry-p" "cherry-pick " &&
> + test_completion "git --namespace=foo cherry-p" "cherry-pick " &&
> + test_completion "git --paginate cherry-p" "cherry-pick " &&
> + test_completion "git --info-path cherry-p" "cherry-pick " &&
> + test_completion "git --no-replace-objects cherry-p" "cherry-pick "
> '
>
> test_expect_success 'setup for ref completion' '
That looks good to me, thanks.
next prev parent reply other threads:[~2013-01-18 5:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 13:35 [PATCH] attr: fix off-by-one directory component length calculation Nguyễn Thái Ngọc Duy
2013-01-15 16:17 ` Junio C Hamano
2013-01-15 19:14 ` Jean-Noël AVILA
2013-01-15 19:29 ` Junio C Hamano
2013-01-15 19:53 ` Jean-Noël AVILA
2013-01-15 20:49 ` Junio C Hamano
2013-01-15 23:24 ` Jeff King
2013-01-16 6:15 ` t9902 fails (Was: [PATCH] attr: fix off-by-one directory component length calculation) Torsten Bögershausen
2013-01-17 22:47 ` Jean-Noël AVILA
2013-01-18 0:04 ` Jonathan Nieder
2013-01-18 0:12 ` t9902 fails Junio C Hamano
2013-01-18 5:20 ` Torsten Bögershausen [this message]
2013-01-18 16:49 ` Junio C Hamano
2013-01-18 20:15 ` Junio C Hamano
2013-01-18 22:23 ` Jean-Noël AVILA
2013-01-18 22:37 ` Junio C Hamano
2013-01-18 22:57 ` Junio C Hamano
2013-01-19 5:38 ` Torsten Bögershausen
2013-01-19 7:52 ` Re* " Junio C Hamano
2013-01-19 8:00 ` [PATCH 1/2] help: include <common-cmds.h> only in one file Junio C Hamano
2013-01-19 8:02 ` [PATCH 2/2] help --standard: list standard commands Junio C Hamano
2013-01-19 10:32 ` Jean-Noël AVILA
2013-01-19 13:43 ` Re* t9902 fails Jean-Noël AVILA
2013-01-19 10:23 ` Jean-Noël AVILA
2013-01-16 1:08 ` [PATCH] attr: fix off-by-one directory component length calculation Duy Nguyen
2013-01-16 2:09 ` Duy Nguyen
2013-01-16 2:33 ` Junio C Hamano
2013-01-16 3:12 ` Duy Nguyen
2013-01-16 5:35 ` Junio C Hamano
2013-01-16 6:02 ` Duy Nguyen
2013-01-16 19:07 ` Junio C Hamano
2013-01-16 1:03 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F8DBBB.7040005@web.de \
--to=tboegi@web.de \
--cc=avila.jn@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).