From: Eric Blake <eblake@redhat.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] notes: mention --notes in more places
Date: Wed, 17 Oct 2012 07:30:56 -0600 [thread overview]
Message-ID: <507EB310.8020904@redhat.com> (raw)
In-Reply-To: <20121017055136.GA12301@sigill.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
On 10/16/2012 11:51 PM, Jeff King wrote:
> It may also make sense to show notes differently when outputting the
> "email" format as format-patch does. E.g., using a triple-dash would
> keep them separate from the commit message when using "git am". Like:
>
> your commit message
>
> Signed-off-by: You
> ---
> your notes go here
That's _precisely_ what I want! I want to use notes as a way of
tracking my edits for what I did in v2 of a patch, at the time I commit
my v2, so that I can send a revised series including the notes in a
manner most efficient for someone else using 'git am' on the series to
see why I sent a v2 but without polluting the upstream repository with
useless versioning information from the email.
>
> We've talked about it several times, but it's never happened (probably
> because most people don't actually use notes).
And people (like me) don't use notes because they aren't documented.
Catch-22, so we have to start somewhere.
I'll submit a v2 with the non-controversial edits, and spend some time
trying to figure out how to isolate the portion of pretty-options.txt
that is relevant to format-patch. If it's easy enough, I can also
consider using --- instead of Notes: as the separator when using
format-patch.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-10-17 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 3:19 [PATCH] notes: mention --notes in more places Eric Blake
2012-10-17 5:14 ` Junio C Hamano
2012-10-17 5:51 ` Jeff King
2012-10-17 6:25 ` Junio C Hamano
2012-10-17 13:30 ` Eric Blake [this message]
2012-10-17 19:05 ` Jeff King
2012-10-17 21:50 ` Junio C Hamano
2012-10-18 12:11 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507EB310.8020904@redhat.com \
--to=eblake@redhat.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).