From: "\"Jan H. Schönherr\"" <schnhrr@cs.tu-berlin.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 0/5] Cure some format-patch wrapping and encoding issues
Date: Wed, 10 Oct 2012 12:49:44 +0200 [thread overview]
Message-ID: <507552C8.2020402@cs.tu-berlin.de> (raw)
In-Reply-To: <7vfw5nfoq9.fsf@alter.siamese.dyndns.org>
Am 09.10.2012 21:07, schrieb Junio C Hamano:
> Jan H. Schönherr <schnhrr@cs.tu-berlin.de> writes:
>
>> During the creation of this series, I came across the strbuf
>> wrapping functions, and I wonder if there is an off-by-one issue.
>>
>> Consider the following excerpt from t4202:
...
>
> Yeah, that does sound like an off-by-one bug. When we as end users
> say %w(72), we do expect some lines fill to the 72nd column, not
> stopping at the 71st. I suspect that dates back to the very first
> implementation of %w() but I think we should fix it (perhaps as a
> separate patch either the earliest or the last in the series).
I will include a fix for that, then.
(But I won't be able the send out the next round of this series
before next week.)
Regards
Jan
prev parent reply other threads:[~2012-10-10 10:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 17:33 [PATCH 0/5] Cure some format-patch wrapping and encoding issues Jan H. Schönherr
2012-10-08 17:33 ` [PATCH 1/5] format-patch: do not wrap non-rfc2047 headers too early Jan H. Schönherr
2012-10-08 17:33 ` [PATCH 2/5] format-patch: do not wrap rfc2047 encoded headers too late Jan H. Schönherr
[not found] ` <7v7gqzfnpj.fsf@alter.siamese.dyndns.org>
2012-10-10 9:31 ` "Jan H. Schönherr"
2012-10-08 17:33 ` [PATCH 3/5] format-patch: introduce helper function last_line_length() Jan H. Schönherr
2012-10-08 17:33 ` [PATCH 4/5] format-patch: fix rfc2047 address encoding with respect to rfc822 specials Jan H. Schönherr
2012-10-08 17:33 ` [PATCH 5/5] format-patch: tests: check rfc822+rfc2047 in to+cc headers Jan H. Schönherr
[not found] ` <7v391nfmzn.fsf@alter.siamese.dyndns.org>
2012-10-10 10:44 ` "Jan H. Schönherr"
2012-10-10 17:02 ` Junio C Hamano
[not found] ` <7vfw5nfoq9.fsf@alter.siamese.dyndns.org>
2012-10-10 10:49 ` "Jan H. Schönherr" [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507552C8.2020402@cs.tu-berlin.de \
--to=schnhrr@cs.tu-berlin.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).