From: Michael Haggerty <mhagger@alum.mit.edu>
To: Ben Walton <bdwalton@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] Remove the hard coded length limit on variable names in config files
Date: Mon, 01 Oct 2012 05:16:56 +0200 [thread overview]
Message-ID: <50690B28.5030408@alum.mit.edu> (raw)
In-Reply-To: <CAP30j15wKa7wbLyaLo8omHcAh5u7O=Yt8Tjy4bD3V_0nT1zJPQ@mail.gmail.com>
On 09/30/2012 08:20 PM, Ben Walton wrote:
>> The patch doesn't apply to the current master; it appears to have been
>> built against master 883a2a3504 (2012-02-23) or older. It will have to
>> be rebased to the current master.
>
> Junio had asked that it be based on maint so that's what I (thought
> I?) did. I'm happy to redo it against master if that's better though.
That explains it. Sorry, I hadn't seen that conversation. (In the
future, if a patch applies against something other than master, please
add a note in the cover letter or in the patch comment after the "--".)
It is OK with me to leave the patch against maint, if that is what Junio
wanted. It would help, though, if you rebase it to the latest maint
(the conflict seems easy to fix).
Thanks,
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2012-10-01 3:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 0:47 [PATCH] Prevent git-config from storing section keys that are too long Ben Walton
2012-09-07 1:33 ` Junio C Hamano
2012-09-07 2:34 ` Ben Walton
2012-09-29 10:19 ` [PATCH] Remove the hard coded length limit on variable names in config files Ben Walton
2012-09-30 4:05 ` Michael Haggerty
2012-09-30 18:20 ` Ben Walton
2012-09-30 19:44 ` Ben Walton
2012-10-01 19:33 ` Junio C Hamano
2012-10-01 3:16 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50690B28.5030408@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=bdwalton@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).