From: Jens Lehmann <Jens.Lehmann@web.de>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] submodule: make 'show' an alias for 'summary'
Date: Sat, 29 Sep 2012 17:27:32 +0200 [thread overview]
Message-ID: <50671364.5030205@web.de> (raw)
In-Reply-To: <CALkWK0nCahg7165_JuJSj7u0UfYRGZgFjJ6O-o=HCwdsPwU-xg@mail.gmail.com>
Am 29.09.2012 17:07, schrieb Ramkumar Ramachandra:
> Jens Lehmann wrote:
>> Am 29.09.2012 15:43, schrieb Ramkumar Ramachandra:
>>> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
>>> ---
>>> Like 'git remote show', 'git stash show'.
>>
>> I understand the analogy to "git stash show" (as that also displays
>> a diff similar to what " git submodule summary" does). But "git
>> remote show" just displays a list of configured remotes, which is
>> something different. And the other command with a "show" option is
>> "git notes show", which causes it to display a note. So I think we
>> are pretty inconsistent here and I see no advantage of adding such
>> an alias for "git submodule summary". What am I missing?
>
> I used submodules for the first time, and expected 'git submodule
> show' to work. It may not be 100% consistent with the other commands,
> but I think the 'summary' is a good match. Either way, I don't feel
> strongly about the patch, so feel free to drop it if you think it's
> inappropriate.
I'm very interested in your feedback as a first time submodule user,
what you wrote above makes sense and explains why you did that patch
(and it would have been nice to read some of it in the commit message
;-). What information did you expect to get from a "git submodule
show" which isn't already provided by "git status" and "git diff"
(especially as they give you some information the "git submodule"
commands don't)?
next prev parent reply other threads:[~2012-09-29 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 13:43 [PATCH] submodule: make 'show' an alias for 'summary' Ramkumar Ramachandra
2012-09-29 13:43 ` [PATCH] submodule: use abbreviated sha1 in 'status' output Ramkumar Ramachandra
2012-09-29 14:31 ` Jens Lehmann
2012-09-29 14:45 ` Ramkumar Ramachandra
2012-09-29 15:05 ` Jens Lehmann
2012-10-01 6:42 ` Ramkumar Ramachandra
2012-10-01 17:22 ` Jens Lehmann
2012-09-29 14:49 ` [PATCH] submodule: make 'show' an alias for 'summary' Jens Lehmann
2012-09-29 15:07 ` Ramkumar Ramachandra
2012-09-29 15:27 ` Jens Lehmann [this message]
2012-10-01 6:45 ` Ramkumar Ramachandra
2012-10-01 17:26 ` Jens Lehmann
2012-10-01 17:33 ` Ramkumar Ramachandra
2012-10-01 19:31 ` Jens Lehmann
2012-10-01 17:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50671364.5030205@web.de \
--to=jens.lehmann@web.de \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).