From: Michael J Gruber <git@drmicha.warpmail.net>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Jialin Liu <jialinliu7@gmail.com>, git@vger.kernel.org
Subject: Re: a error in git documentation
Date: Tue, 31 Jul 2012 10:38:18 +0200 [thread overview]
Message-ID: <5017997A.70406@drmicha.warpmail.net> (raw)
In-Reply-To: <vpqpq7c1ll0.fsf@bauges.imag.fr>
Matthieu Moy venit, vidit, dixit 31.07.2012 08:38:
> Jialin Liu <jialinliu7@gmail.com> writes:
>
>> In http://git-scm.com/book/en/Git-Basics-Recording-Changes-to-the-Repository
>>
>> Notice how you don’t have to run git add on the benchmarks.rb file in this case before you commit.
>
> In which case? (the page is rather long)
>
> I didn't see a case where "git add" was not needed (or "git commit" used
> with "-a", which gives the same effect).
>
Matthieu: "Notice how..." is the line Jialin suggest to be changed.
Jialin: "how" is correct; "how" starts a subsentence (subclause) which
is used as the object for the verb "notice". ("Notice [that] now..."
would be correct, too.)
BTW: This is not in what many would call "git documentation" (i.e.
git.git/Documentation/). It's in the Git book. But git-scm calls the the
former "reference" and puts both under "Documentation".
This is not about the question "who's the Git community". It's simply
(im)practical: You contribute to the Git book via pull requests on
GitHub and to "git documentation within the git project" by patches on
this list.
Michael
prev parent reply other threads:[~2012-07-31 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 2:38 a error in git documentation Jialin Liu
2012-07-31 6:38 ` Matthieu Moy
2012-07-31 8:38 ` Michael J Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5017997A.70406@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=jialinliu7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).