From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 0/2] test results for v1.7.12-rc0 on cygwin
Date: Sun, 29 Jul 2012 10:57:10 +0200 [thread overview]
Message-ID: <5014FAE6.7080009@lsrfire.ath.cx> (raw)
In-Reply-To: <50143379.8050500@ramsay1.demon.co.uk>
Am 28.07.2012 20:46, schrieb Ramsay Jones:
> Unfortunately, I was unable to reproduce the final failure in t7810-grep.sh.
> I tried, among other things, to provoke a failure thus:
>
> $ for i in $(seq 100); do
> > if ! ./t7810-grep.sh -i -v; then
> > break;
> > fi
> > done
> $
>
> but, apart from chewing on the cpu for about 50 minutes, it didn't result
> in a failure. :(
>
> However, after looking at test 59, it seems to me to be a stale (redundant)
> test. So, patch #2 removes that test! :-D [I wish I could reproduce the
> failure because I don't like not knowing why it failed, but ...]
Removing the test makes sense, since it was needed for --ext-grep only,
is relatively expensive and a bit fragile (by depending on MAXARGS).
I'm slightly worried about the non-reproducible failure, though.
Perhaps a timing issue is involved and chances are higher if you leave
out the option -v?
Thanks,
René
next prev parent reply other threads:[~2012-07-29 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 18:46 [PATCH 0/2] test results for v1.7.12-rc0 on cygwin Ramsay Jones
2012-07-29 8:57 ` René Scharfe [this message]
2012-07-29 20:33 ` Junio C Hamano
2012-07-31 17:38 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5014FAE6.7080009@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).