From: Derrick Stolee <stolee@gmail.com>
To: "Martin Ågren" <martin.agren@gmail.com>, git@vger.kernel.org
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH 3/4] sha1-lookup: rename `sha1_pos()` as `hash_pos()`
Date: Tue, 29 Dec 2020 20:21:27 -0500 [thread overview]
Message-ID: <4f719985-a1cb-b9ab-74aa-d8e305a8f7e6@gmail.com> (raw)
In-Reply-To: <8d3b123633d37218587bb2e71232631dea420156.1609282997.git.martin.agren@gmail.com>
On 12/29/2020 6:52 PM, Martin Ågren wrote:
> Rename this function to reflect that we're not just able to handle SHA-1
> these days. There are a few instances of "sha1" left in sha1-lookup.[ch]
> after this, but those will be addressed in the next commit.
...
> @@ -74,7 +74,7 @@ int sha1_pos(const unsigned char *hash, void *table, size_t nr,
> if (lov != hiv) {
> /*
> * At this point miv could be equal
> - * to hiv (but sha1 could still be higher);
> + * to hiv (but hash could still be higher);
Thanks for catching this comment, too!
-Stolee
next prev parent reply other threads:[~2020-12-30 1:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 23:52 [PATCH 0/4] rename "sha1-foo" files Martin Ågren
2020-12-29 23:52 ` [PATCH 1/4] object-name.c: rename from sha1-name.c Martin Ågren
2020-12-30 1:19 ` Derrick Stolee
2020-12-29 23:52 ` [PATCH 2/4] object-file.c: rename from sha1-file.c Martin Ågren
2020-12-29 23:52 ` [PATCH 3/4] sha1-lookup: rename `sha1_pos()` as `hash_pos()` Martin Ågren
2020-12-30 1:21 ` Derrick Stolee [this message]
2020-12-29 23:53 ` [PATCH 4/4] hash-lookup: rename from sha1-lookup Martin Ågren
2020-12-30 1:29 ` [PATCH 0/4] rename "sha1-foo" files Derrick Stolee
2020-12-30 8:01 ` Martin Ågren
2020-12-30 13:35 ` Derrick Stolee
2020-12-30 4:22 ` brian m. carlson
2020-12-30 8:04 ` Martin Ågren
2020-12-31 11:56 ` [PATCH v2 " Martin Ågren
2020-12-31 11:56 ` [PATCH v2 1/4] object-name.c: rename from sha1-name.c Martin Ågren
2020-12-31 11:56 ` [PATCH v2 2/4] object-file.c: rename from sha1-file.c Martin Ågren
2020-12-31 11:56 ` [PATCH v2 3/4] sha1-lookup: rename `sha1_pos()` as `hash_pos()` Martin Ågren
2020-12-31 11:56 ` [PATCH v2 4/4] hash-lookup: rename from sha1-lookup Martin Ågren
2020-12-31 12:47 ` [PATCH v2 0/4] rename "sha1-foo" files Derrick Stolee
2020-12-31 13:36 ` Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f719985-a1cb-b9ab-74aa-d8e305a8f7e6@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).