* [PATCH] t9001: PATH must not use Windows-style paths
@ 2021-08-24 18:01 Johannes Sixt
2021-08-25 12:27 ` Johannes Schindelin
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Sixt @ 2021-08-24 18:01 UTC (permalink / raw)
To: Gregory Anders; +Cc: Git Mailing List, Johannes Schindelin
On Windows, $(pwd) returns a drive-letter style path C:/foo, while $PWD
contains a POSIX style /c/foo path. When we want to interpolate the
current directory in the PATH variable, we must not use the C:/foo style,
because the meaning of the colon is ambiguous. Use the POSIX style.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
This belongs on top of branch ga/send-email-sendmail-cmd.
t/t9001-send-email.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 57fc10e7f8..595cbad372 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -2198,7 +2198,7 @@ test_expect_success $PREREQ 'leading and trailing whitespaces are removed' '
test_expect_success $PREREQ 'test using command name with --sendmail-cmd' '
clean_fake_sendmail &&
- PATH="$(pwd):$PATH" \
+ PATH="$PWD:$PATH" \
git send-email \
--from="Example <nobody@example.com>" \
--to=nobody@example.com \
--
2.33.0.129.g739793498e
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t9001: PATH must not use Windows-style paths
2021-08-24 18:01 [PATCH] t9001: PATH must not use Windows-style paths Johannes Sixt
@ 2021-08-25 12:27 ` Johannes Schindelin
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2021-08-25 12:27 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Gregory Anders, Git Mailing List
Hi Hannes,
On Tue, 24 Aug 2021, Johannes Sixt wrote:
> On Windows, $(pwd) returns a drive-letter style path C:/foo, while $PWD
> contains a POSIX style /c/foo path. When we want to interpolate the
> current directory in the PATH variable, we must not use the C:/foo style,
> because the meaning of the colon is ambiguous. Use the POSIX style.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Thank you,
Dscho
> ---
> This belongs on top of branch ga/send-email-sendmail-cmd.
>
> t/t9001-send-email.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 57fc10e7f8..595cbad372 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -2198,7 +2198,7 @@ test_expect_success $PREREQ 'leading and trailing whitespaces are removed' '
>
> test_expect_success $PREREQ 'test using command name with --sendmail-cmd' '
> clean_fake_sendmail &&
> - PATH="$(pwd):$PATH" \
> + PATH="$PWD:$PATH" \
> git send-email \
> --from="Example <nobody@example.com>" \
> --to=nobody@example.com \
> --
> 2.33.0.129.g739793498e
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-25 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 18:01 [PATCH] t9001: PATH must not use Windows-style paths Johannes Sixt
2021-08-25 12:27 ` Johannes Schindelin
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).