From: Peter Krefting <peter@softwolves.pp.se>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
Jeff King <peff@peff.net>,
git@vger.kernel.org, "Osipov,
Michael (IN IT IN)" <michael.osipov@innomotics.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2] bisect: Honor log.date
Date: Tue, 16 Apr 2024 20:53:40 +0100 (CET) [thread overview]
Message-ID: <4f0456c0-e926-ee60-4e14-6b8ed80d2ace@softwolves.pp.se> (raw)
In-Reply-To: <xmqq8r1dfh65.fsf@gitster.g>
Junio C Hamano:
> then the codepath we are changing from using diff-tree to show can
> do something like:
>
> struct git_global_state state = GIT_GLOBAL_STATE_INIT;
> struct strvec args = STRVEC_INIT;
>
> strvec_pushl(&args, ...);
> cmd__show(&state, args.nr , args.v);
>
> and expect that cmd__show() will do the _right thing_, right?
In this particular case, calling "git show" is really the last thing
we want to do; so if we can move the cleanup that happens after it
(that ends the bisect), it should be able to just take over the
current process with a call to show, without needing to re-exec.
And calling back to the libification question, I would see this part
of the bisect command to be something that would run *on top of* the
library (with possibly an API to poke bad/good states into it), so I
don't think that objection holds for this particular case.
--
\\// Peter - http://www.softwolves.pp.se/
next prev parent reply other threads:[~2024-04-16 19:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 23:10 [PATCH v2] bisect: Honor log.date Peter Krefting
2024-03-31 2:14 ` Junio C Hamano
2024-03-31 17:10 ` Peter Krefting
2024-03-31 22:58 ` Junio C Hamano
2024-04-01 2:32 ` Jeff King
2024-04-01 15:50 ` Peter Krefting
2024-04-01 16:32 ` Jeff King
2024-04-01 17:03 ` Junio C Hamano
2024-04-03 1:27 ` Jeff King
2024-04-16 11:01 ` Christian Couder
2024-04-16 15:42 ` Junio C Hamano
2024-04-16 19:53 ` Peter Krefting [this message]
2024-04-20 17:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f0456c0-e926-ee60-4e14-6b8ed80d2ace@softwolves.pp.se \
--to=peter@softwolves.pp.se \
--cc=Johannes.Schindelin@gmx.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michael.osipov@innomotics.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).