git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: Yuchen Ying <ych@google.com>, git@vger.kernel.org
Subject: Re: No edit option when "git add --patch" a new file
Date: Wed, 9 Sep 2020 10:33:16 +0100	[thread overview]
Message-ID: <4eb2c8ec-3ee3-5097-9cff-b650caf2c888@gmail.com> (raw)
In-Reply-To: <CAF6j4hcSEhNvS-DYgNLNn3TdH1vkhgHZRC0fqWer_XM0PQxgYA@mail.gmail.com>

On 08/09/2020 17:16, Yuchen Ying wrote:
> Hi list,
> 
> I was attempting to "add --patch" a newly created file but the "edit"
> option is not provided.
> 
> Steps to reproduce this problem:
> 
> $ echo "test\ntest" > test
> $ git add -N test
> $ git add -p test
> 
> Expected: e is an option
> Got:
> 
> $ git add -p
> diff --git a/terraform/test b/terraform/test
> index 0000000..992533b
> --- /dev/null
> +++ b/terraform/test
> new file mode 100644
> @@ -0,0 +1,2 @@
> +asdf
> +asdf
> (1/1) Stage addition [y,n,q,a,d,?]? e
> Sorry, cannot edit this hunk

Thanks for taking the time to report this issue. I'm currently working
on a fix which I hope to post later today as the issue was previously
reported at
https://public-inbox.org/git/CAB+jsAW_+NTJjDLG9uMrf4cc5rcwHLD5kTLk7QgvFCgryb22Gw@mail.gmail.com/
I'll Cc you on the patch

Best Wishes

Phillip


      reply	other threads:[~2020-09-09  9:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 16:16 No edit option when "git add --patch" a new file Yuchen Ying
2020-09-09  9:33 ` Phillip Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4eb2c8ec-3ee3-5097-9cff-b650caf2c888@gmail.com \
    --to=phillip.wood123@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ych@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).