git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Stefan Beller <sbeller@google.com>, git <git@vger.kernel.org>
Subject: Re: The state of the object store series
Date: Thu, 21 Jun 2018 20:59:46 -0400
Message-ID: <4e7600f1-6dd0-3b21-5f5d-26af2b3c0b1a@gmail.com> (raw)
In-Reply-To: <CAGZ79kZtEZA1rvgfSCS+m4dsrB86Cf-XiePWQmeU-kCNxP_NLQ@mail.gmail.com>

[My email client says I sent this two days ago, but it doesn't appear on 
public-inbox.org, so somehow it didn't land on-list (Stefan pointed out 
that the message was in HTML). Repeating the message now so I can 
reference it in another discussion. -Stolee]

On 6/19/2018 6:07 PM, Stefan Beller wrote:
> There is an ongoing effort to remove global state currently and switch over
> to pass around the relevant data structures; for most of it we end up passing
> around 'the_repository' as it contains everything there is.
>
> Merged into master:
>
> fcb6df32546 Merge branch 'sb/oid-object-info'
> a2cec42213c Merge branch 'sb/object-store-replace'
> 3a1ec60c43b Merge branch 'sb/packfiles-in-repository'
> cf0b1793ead Merge branch 'sb/object-store'
>
> Currently cooking:
>
> 8c69a7d7e80 Merge branch 'sb/object-store-grafts' into pu
> 42d32d07298 Merge branch 'sb/object-store-alloc' into jch
>
> (both marked for "will merge to next" in the cooking report)
>
> Floating on the mailing list, not cooking yet:
>
> "sb/object-store-lookup" 
> https://public-inbox.org/git/20180613230522.55335-1-sbeller@google.com/ 
> This clashes with other series in flight (Stolees get_tree series; see 
> https://public-inbox.org/git/709bd61c-70fc-a925-efba-58ab9be265c9@gmail.com/ 
> I'll rebase this series on top of that series once the currently 
> cooking series stabilize) "nd/kill-the_index" 
> https://public-inbox.org/git/20180616054157.32433-1-pclouds@gmail.com/ 
> This converts the_index to pass around index pointers instead of 
> the_repository; it fits into the theme, but Duys end goal differs from 
> mine; he is less submodule focused. Work that still needs to be done: "xx/object-store-commit-graph"
>    Convert the commit graph to have no global state, but be part of the
>    repository struct. I think this can go in parallel to
> "sb/object-store-lookup",
>    so I'll tackle that next. Thanks Stolee for looking ahead: There is only the
>    commit graph itself as well as whether it has been prepared as a global
>    variable. So this series will consist of passing around a repository struct
>    for all those higher level functions that do not pass around the commit graph
>    or parts of it.

There are some patches in ds/commit-graph-fsck that would be helpful for 
this effort, and may be easier for you to take.

Specifically, these ones:

  - commit-graph: load a root tree from specific graph
  - commit: force commit to parse from object database
  - commit-graph: parse commit from chosen graph

I'm waiting for sb/object-store-lookup to be in 'next' before I re-roll 
that branch. If you're not in a rush to send this series, perhaps wait 
for the next version here.

> "xx/finish-object-stores"
>    This requires "xx/object-store-commit-graph" as well as
> "sb/object-store-lookup";
>    it will convert parse_commit[_gently] to take a repository argument and will
>    finish the actual object store part. This might be optional for the goal of
>    converting submodules, that I have in mind, but it sure is a nice finishing
>    touch.
>
> "xx/convert-revision-walking"
>    This series aims to convert get_merge_bases(), in_merge_bases() and all its
>    revision walking code to take a repository argument.

I'm playing around with a series that groups most commit walks into one 
file, so they can share more code and we can more easily test their 
correctness and performance. I'll send an RFC sometime that will 
absolutely collide with this one, but I expect a full v1 patch will be 
based on this series.

Thanks,

-Stolee


  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19 22:07 Stefan Beller
2018-06-19 22:37 ` Jonathan Tan
2018-06-19 22:41   ` Stefan Beller
2018-06-20 15:12 ` Duy Nguyen
2018-06-22  0:59 ` Derrick Stolee [this message]
2018-06-22 17:12   ` Jonathan Tan

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e7600f1-6dd0-3b21-5f5d-26af2b3c0b1a@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox