From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 1DE141FF40 for ; Thu, 22 Dec 2016 06:13:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751070AbcLVGNK (ORCPT ); Thu, 22 Dec 2016 01:13:10 -0500 Received: from bsmtp1.bon.at ([213.33.87.15]:18233 "EHLO bsmtp1.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750934AbcLVGNK (ORCPT ); Thu, 22 Dec 2016 01:13:10 -0500 Received: from dx.site (unknown [93.83.142.38]) by bsmtp1.bon.at (Postfix) with ESMTPSA id 3tkh5w5739z5tlK; Thu, 22 Dec 2016 07:13:08 +0100 (CET) Received: from [IPv6:::1] (localhost [IPv6:::1]) by dx.site (Postfix) with ESMTP id 5932F2222; Thu, 22 Dec 2016 07:13:08 +0100 (CET) Subject: Re: [PATCH 4/2] t5615-alternate-env: double-quotes in file names do not work on Windows To: Jeff King References: <20161212194929.bdcihf7orjabzb2h@sigill.intra.peff.net> <20161212195355.znqlu44lgnke3ltc@sigill.intra.peff.net> <00b6235d-c1bc-30c2-6539-6c78c4ce9eb0@kdbg.org> <20161221224222.6fn6irefmd6li6oa@sigill.intra.peff.net> Cc: Junio C Hamano , Klaus Ethgen , git@vger.kernel.org From: Johannes Sixt Message-ID: <4e66fba1-d881-6a96-1e4d-da9c897353ac@kdbg.org> Date: Thu, 22 Dec 2016 07:13:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161221224222.6fn6irefmd6li6oa@sigill.intra.peff.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 21.12.2016 um 23:42 schrieb Jeff King: > On Wed, Dec 21, 2016 at 10:33:43PM +0100, Johannes Sixt wrote: > >> Protect a recently added test case with !MINGW. >> >> Signed-off-by: Johannes Sixt >> --- >> I don't remember why I did not notice this failure sooner. >> Perhaps I did, but then ran out of time to debug it... >> >> The patch should go on top of jk/quote-env-path-list-component. >> [...] >> -test_expect_success 'broken quoting falls back to interpreting raw' ' >> +test_expect_success !MINGW 'broken quoting falls back to interpreting raw' ' >> mv one.git \"one.git && >> check_obj \"one.git/objects <<-EOF >> $one blob > > Hmph. I explicitly avoided a colon in the filename so that it would run > on MINGW. Is a double-quote also not allowed? It is not allowed; that was my conclusion. But now that you ask, I'll double-check. -- Hannes