Re: What's cooking in git.git (Dec 2021, #01; Fri, 3)

[Phillip Wood <phillip.wood123@gmail.com>]

Hi Dscho

On 08/12/2021 12:42, Johannes Schindelin wrote:
> Hi Phillip,
> 
> On Mon, 6 Dec 2021, Phillip Wood wrote:
> 
>> On 04/12/2021 01:37, Junio C Hamano wrote:
>>
>>> * pw/diff-color-moved-fix (2021-10-27) 15 commits
>>>    - diff --color-moved: intern strings
>>>    - diff: use designated initializers for emitted_diff_symbol
>>>    - diff --color-moved-ws=allow-indentation-change: improve hash lookups
>>>    - diff --color-moved: stop clearing potential moved blocks
>>>    - diff --color-moved: shrink potential moved blocks as we go
>>>    - diff --color-moved: unify moved block growth functions
>>>    - diff --color-moved: call comparison function directly
>>>    - diff --color-moved-ws=allow-indentation-change: simplify and optimize
>>>    - diff: simplify allow-indentation-change delta calculation
>>>    - diff --color-moved: avoid false short line matches and bad zerba
>>>    coloring
>>>    - diff --color-moved=zebra: fix alternate coloring
>>>    - diff --color-moved: rewind when discarding pmb
>>>    - diff --color-moved: factor out function
>>>    - diff --color-moved: clear all flags on blocks that are too short
>>>    - diff --color-moved: add perf tests
>>>
>>>    Long-overdue correctness and performance update to "diff
>>>    --color-moved" feature.
>>>
>>>    Need to pick up the reroll before merging to 'next'.
>>>    cf. <pull.981.v4.git.1637056178.gitgitgadget@gmail.com>
>>
>> Dscho spotted a typo which I was going to correct with a re-roll but I've been
>> holding off in case he has time to read the rest of the series.
> 
> I would have loved to give this a much more in-depth review, but the days
> have become short on the North hemisphere, haven't they.

I know, it felt like it never got light here yesterday.

> In any case, the patch series looks good to me (personally, I do not care
> so much about typos as long as they aren't indicator of sloppiness, which
> in this case they aren't, I find your patches really well done).

I've just posted v5 with the typo fixed, thanks for your comments.

Phillip