From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by dcvr.yhbt.net (Postfix) with ESMTP id 9978D207BC
	for <e@80x24.org>; Wed, 19 Apr 2017 06:00:54 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759900AbdDSGAw (ORCPT <rfc822;e@80x24.org>);
        Wed, 19 Apr 2017 02:00:52 -0400
Received: from bsmtp1.bon.at ([213.33.87.15]:1550 "EHLO bsmtp1.bon.at"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1759664AbdDSGAv (ORCPT <rfc822;git@vger.kernel.org>);
        Wed, 19 Apr 2017 02:00:51 -0400
Received: from dx.site (unknown [93.83.142.38])
        by bsmtp1.bon.at (Postfix) with ESMTPSA id 3w7BFF4dJnz5tlJ;
        Wed, 19 Apr 2017 08:00:49 +0200 (CEST)
Received: from [IPv6:::1] (localhost [IPv6:::1])
        by dx.site (Postfix) with ESMTP id 3F4B242B3;
        Wed, 19 Apr 2017 08:00:49 +0200 (CEST)
Subject: Re: [PATCH v5 11/11] run-command: block signals between fork and
 execve
To:     Brandon Williams <bmwill@google.com>
References: <20170417220818.44917-1-bmwill@google.com>
 <20170418231805.61835-1-bmwill@google.com>
 <20170418231805.61835-12-bmwill@google.com>
Cc:     git@vger.kernel.org, Eric Wong <e@80x24.org>, jrnieder@gmail.com
From:   Johannes Sixt <j6t@kdbg.org>
Message-ID: <4c2f91fd-c9bd-cfe0-4e2d-3f1669410579@kdbg.org>
Date:   Wed, 19 Apr 2017 08:00:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170418231805.61835-12-bmwill@google.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Am 19.04.2017 um 01:18 schrieb Brandon Williams:
> @@ -400,6 +404,53 @@ static char **prep_childenv(const char *const *deltaenv)
>  }
>  #endif
>

Does this #endif in this hunk context belong to an #ifndef 
GIT_WINDOWS_NATIVE? If so, I wonder why these new functions are outside 
these brackets? An oversight?

> +struct atfork_state {
> +#ifndef NO_PTHREADS
> +	int cs;
> +#endif
> +	sigset_t old;
> +};
...

-- Hannes