From: Ibrahim El <ibrahim.el@pm.me>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 1/5] Signing API: Added documentation for the new signing interface
Date: Tue, 27 Aug 2019 18:52:15 +0000 [thread overview]
Message-ID: <4buvJvYppITFRis3i5T-P7sOf9Uwdm_dplQvZHfKPGWWy0kTU42vG844ksZBUvsA0rNWosfSyHLGp5pvcx_bNn9wFI9oiTddoke9N7LHNjc=@pm.me> (raw)
In-Reply-To: <20190826224646.GA11334@genre.crustytoothpaste.net>
Thx for your feedback. I will incorporate the changes and re-submit the patches.
Ibrahim El
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Monday, August 26, 2019 10:46 PM, brian m. carlson <sandals@crustytoothpaste.net> wrote:
> On 2019-08-26 at 19:57:53, Ibrahim El wrote:
>
> > From: Ibrahim El Rhezzali ibrahim.el@pm.me
> > 2f8f82549 Added documentation for the new signing interface
>
> This seems out of place. Also, your commit summary isn't in the
> imperative mood. See Documentation/SubmittingPatches for more details.
>
> > This contains a model document and updated Documentation detailing new interface and config aliases and their description
>
> You'll probably want to wrap your commit messages at 72 characters.
>
> > diff --git a/Documentation/config/signing.txt b/Documentation/config/signing.txt
> > new file mode 100644
> > index 000000000..b6b8b8825
> > --- /dev/null
> > +++ b/Documentation/config/signing.txt
> > @@ -0,0 +1,63 @@
> > +signing.default::
> >
> > - The default signing format to use when signing commits and tags.
> > - The value must be one of: "openpgp", "x509", or "bettersign".
> > - The default value is "openpgp".
> > ++
> > +The default executable to run for "openpgp" is "`gpg`", for "x509" is
> > +"`gpgsm`", and for "bettersign" is "`bs`".
> > ++
> > +The "bettersign" tool can be found here:
> > +https://github.com/dhuseby/bs
> >
>
> I don't think we want to introduce the use of this tool. The repository
> contains three commits starting in May of this year. GnuPG's gpg and
> gpgsm tools have been around a long time and implement IETF-standardized
> protocols that are mature and have been well researched. This tool
> doesn't seem to meet that threshold.
>
> It should be fine to set up the API such that one could use it if they
> wanted to with appropriate configuration, but I don't think we want to
> add support for it by default.
>
> > diff --git a/Documentation/technical/signing-interface.png b/Documentation/technical/signing-interface.png
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..1a44a7f665d4a546ac6f18fb10208547e6a5fced
> > GIT binary patch
> > literal 76116
>
> This doesn't appear to be used in this patch, and the commit message
> doesn't explain why it's included. I haven't looked at it, but if it's
> a chart of some sort, we usually prefer ASCII art for that purpose.
>
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> brian m. carlson: Houston, Texas, US
> OpenPGP: https://keybase.io/bk2204
prev parent reply other threads:[~2019-08-27 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 19:57 [PATCH 1/5] Signing API: Added documentation for the new signing interface Ibrahim El
2019-08-26 22:46 ` brian m. carlson
2019-08-27 18:52 ` Ibrahim El [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='4buvJvYppITFRis3i5T-P7sOf9Uwdm_dplQvZHfKPGWWy0kTU42vG844ksZBUvsA0rNWosfSyHLGp5pvcx_bNn9wFI9oiTddoke9N7LHNjc=@pm.me' \
--to=ibrahim.el@pm.me \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).