From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 7568E1F403 for ; Wed, 12 Oct 2022 18:52:50 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KKeexWcN"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229975AbiJLSwr (ORCPT ); Wed, 12 Oct 2022 14:52:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbiJLSwl (ORCPT ); Wed, 12 Oct 2022 14:52:41 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CD5CF41AB for ; Wed, 12 Oct 2022 11:52:39 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id r3-20020a05600c35c300b003b4b5f6c6bdso1794964wmq.2 for ; Wed, 12 Oct 2022 11:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=49A0L1wMbmU0RvsqsmDPtIsptTiM40AWpEgBd9ZjT4Y=; b=KKeexWcNgUF568UqXPP+tTcB6yz6PpTYmaLfd37mffj18HSz6DiJ2ykK9AZGPi3g+q bBC8REXZq0W0if4Q34i+YrYyj+4pB4qMKcRYYY22X79EJbGasrivz2r/hxsj67VUeWEl bc61u3fKg5mz1vyDWVuYCWQD3alV/EIBut+Tq29rOr5vl0sryHSNvM3VnCvzVHfhtVOE vder7neB4w8QmVah/f/pBVIPcfeg6WdeVKf8+zoVuO/TqxatXluojF5mwNoo1Gq1XebS 2LrEu/JJPz0FKLHBDm+crWYZp0V0dLLteWOO7QypVhThUCQcP5YPhzBDMda+YwcgaS3S VrFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=49A0L1wMbmU0RvsqsmDPtIsptTiM40AWpEgBd9ZjT4Y=; b=YBVGmVq7evxcEtqvpMD+qlTb61GhXPNOOsOSHUa+ER6bFWSW7rwRusclmMjqAfUYAV NHQLNl9hyA3Ay5cYf9PzlsqQ4wFfLd0my0yknN8ACoHrnfZJhVvsQuYaBwEFb6qwGhcI bsqhgHABQ4bWijO2yVkFRfOMSQv0PwDcQ5VKYS+7WcC1sLg6672XKRfLFg6MTuwkqJmm 6VQcmtTaHilFHrp3wwSohiMh3FDoUQ1dhndsdqmZb6pHvVFYc/+A/bD5uPdlC0fWf+ok FnnCNHbwVYNd1BWXtsUlGQWAOlcYFqo63xU+ATfbQDCoiMvOAIB5wJ+H6wFYVOAuDnQ2 cDHQ== X-Gm-Message-State: ACrzQf1+rnWeyEvQjCuWJYOvxqgQ0zsH5XPtK1vQgAs22TGx9yY51Xtf WcWAD6l0IoY6dREQ3wfq3QrazfYGIPY= X-Google-Smtp-Source: AMsMyM4pGa2Rwm/aTWa4H3Nc99AYuHDr/3FZFLqlW1zIPQDkf30cAdUrWDtmlg890vfNI6NWCtEFBA== X-Received: by 2002:a1c:3b41:0:b0:3bd:9167:c51e with SMTP id i62-20020a1c3b41000000b003bd9167c51emr3747563wma.102.1665600757446; Wed, 12 Oct 2022 11:52:37 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id k13-20020a05600c0b4d00b003bf3fe1d0c4sm2432310wmr.22.2022.10.12.11.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 11:52:36 -0700 (PDT) Message-Id: <4bf78e356e23c947b8328a91ba435a357cd51f43.1665600750.git.gitgitgadget@gmail.com> In-Reply-To: References: From: "Jeff Hostetler via GitGitGadget" Date: Wed, 12 Oct 2022 18:52:28 +0000 Subject: [PATCH v2 5/7] trace2: convert ctx.thread_name from strbuf to pointer Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: =?UTF-8?Q?=C3=86var_Arnfj=C3=B6r=C3=B0?= Bjarmason , Jeff Hostetler , Derrick Stolee , Jeff Hostetler , Jeff Hostetler Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Jeff Hostetler Convert the `tr2tls_thread_ctx.thread_name` field from a `strbuf` to a "const char*" pointer. The `thread_name` field is a constant string that is constructed when the context is created. Using a (non-const) `strbuf` structure for it caused some confusion in the past because it implied that someone could rename a thread after it was created. That usage was not intended. Change it to a const pointer to make the intent more clear. Signed-off-by: Jeff Hostetler --- trace2/tr2_tgt_event.c | 2 +- trace2/tr2_tgt_perf.c | 2 +- trace2/tr2_tls.c | 16 +++++++++------- trace2/tr2_tls.h | 2 +- 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/trace2/tr2_tgt_event.c b/trace2/tr2_tgt_event.c index 37a3163be12..52f9356c695 100644 --- a/trace2/tr2_tgt_event.c +++ b/trace2/tr2_tgt_event.c @@ -90,7 +90,7 @@ static void event_fmt_prepare(const char *event_name, const char *file, jw_object_string(jw, "event", event_name); jw_object_string(jw, "sid", tr2_sid_get()); - jw_object_string(jw, "thread", ctx->thread_name.buf); + jw_object_string(jw, "thread", ctx->thread_name); /* * In brief mode, only emit