From: Phillip Wood <phillip.wood123@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Samuel Čavoj" <samuel@cavoj.net>,
git@vger.kernel.org,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2 1/2] sequencer: fix gpg option passed to merge subcommand
Date: Fri, 16 Oct 2020 18:25:05 +0100 [thread overview]
Message-ID: <4bbf0055-ed50-6560-7208-dce9378389c8@gmail.com> (raw)
In-Reply-To: <xmqqy2k6cejl.fsf@gitster.c.googlers.com>
On 16/10/2020 17:37, Junio C Hamano wrote:
> Phillip Wood <phillip.wood123@gmail.com> writes:
>
>> ... Reviewers that only read the patch without loading up the
>> test file in their editor have no indication that the test should be
>> clearing the config variable.
>
> It is not a review if the code being updated is not checked for
> sanity in its own context, is it?
It is disappointing that you have chosen to cut the original to those
few lines and reply just to them. The original message made the broader
point that having to check the previous tests in a file to figure out
what the state is at the beginning of any new test that gets added makes
life harder than it needs to be both for contributors and reviewers.
Phillip
next prev parent reply other threads:[~2020-10-16 17:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 23:49 [PATCH v2 1/2] sequencer: fix gpg option passed to merge subcommand Samuel Čavoj
2020-10-12 23:49 ` [PATCH v2 2/2] sequencer: pass explicit --no-gpg-sign to merge Samuel Čavoj
2020-10-13 4:46 ` Junio C Hamano
2020-10-13 10:03 ` Phillip Wood
2020-10-12 23:52 ` [PATCH v2 1/2] sequencer: fix gpg option passed to merge subcommand Samuel Čavoj
2020-10-13 9:55 ` Phillip Wood
2020-10-13 10:43 ` Samuel Čavoj
2020-10-13 13:15 ` Phillip Wood
2020-10-13 10:02 ` Phillip Wood
2020-10-13 10:51 ` Samuel Čavoj
2020-10-13 13:28 ` Phillip Wood
2020-10-13 22:06 ` Junio C Hamano
2020-10-13 23:45 ` Samuel Čavoj
2020-10-14 15:31 ` Junio C Hamano
2020-10-16 13:40 ` Phillip Wood
2020-10-16 16:37 ` Junio C Hamano
2020-10-16 17:25 ` Phillip Wood [this message]
2020-10-16 20:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bbf0055-ed50-6560-7208-dce9378389c8@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=samuel@cavoj.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).