From: Johannes Sixt <j6t@kdbg.org>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Prathamesh Chavan <pc44800@gmail.com>,
git@vger.kernel.org, bmwill@google.com,
christian.couder@gmail.com, sbeller@google.com
Subject: Re: [GSoC][PATCH v5 3/3] submodule: port subcommand foreach from shell to C
Date: Sat, 27 May 2017 23:24:49 +0200 [thread overview]
Message-ID: <4ba646ee-ca8a-f8c1-3ba2-2a108852c98e@kdbg.org> (raw)
In-Reply-To: <ef0b2850-ad3b-e33d-37b7-ece9a305a7a4@ramsayjones.plus.com>
Am 27.05.2017 um 16:06 schrieb Ramsay Jones:
> To be more explicit, last Sunday I hacked into t7407 to show an
> example failure on cygwin (see patch below), but it passes on both
> Linux (expected) and cygwin! :( Perhaps you can see what I'm doing
> wrong?
As long as the git.exe you are using here is Cygwin's, Windows
conventions do not apply. I think, the environment is transfered across
the exec boundaries using Cygwin's own tools, and Windows's
case-insensitive environment does not enter the game at all. But that's
just a shot in the dark.
>
> ATB,
> Ramsay Jones
>
> -- >8 --
> Date: Sun, 21 May 2017 16:23:58 +0100
> Subject: [PATCH] submodule: foreach $path munging on cygwin
>
> ---
> t/t7407-submodule-foreach.sh | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/t/t7407-submodule-foreach.sh b/t/t7407-submodule-foreach.sh
> index 6ba5daf42..c2d66bab7 100755
> --- a/t/t7407-submodule-foreach.sh
> +++ b/t/t7407-submodule-foreach.sh
> @@ -68,17 +68,36 @@ Entering 'sub3'
> $pwd/clone-foo3-sub3-$sub3sha1
> EOF
>
> +cat >expect-func <<EOF
> +Entering 'sub1'
> +running from TRASH
> +path is <<sub1>>
> +Entering 'sub3'
> +running from TRASH
> +path is <<sub3>>
> +EOF
> +
> test_expect_success 'test basic "submodule foreach" usage' '
> + PATH="$PWD:$PATH" &&
> + write_script foreach-func <<-\EOF &&
> + echo "running from TRASH"
> + echo "path is <<$1>>"
> + EOF
> git clone super clone &&
> (
> cd clone &&
> git submodule update --init -- sub1 sub3 &&
> git submodule foreach "echo \$toplevel-\$name-\$path-\$sha1" > ../actual &&
> + git submodule foreach "foreach-func \$path" > ../actual-func1 &&
> + git submodule foreach "export path; foreach-func \$path" > ../actual-func2 &&
> git config foo.bar zar &&
> git submodule foreach "git config --file \"\$toplevel/.git/config\" foo.bar"
> ) &&
> + test_i18ncmp expect-func actual-func1 &&
> + test_i18ncmp expect-func actual-func2 &&
> test_i18ncmp expect actual
> '
> +test_done
>
> cat >expect <<EOF
> Entering '../sub1'
>
next prev parent reply other threads:[~2017-05-27 21:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 17:05 [GSoC][RFC/PATCH] submodule: port subcommand foreach from shell to C Prathamesh Chavan
2017-04-19 18:08 ` Stefan Beller
2017-04-22 19:58 ` [GSoC][RFC/PATCH v2] " Prathamesh Chavan
2017-04-24 2:24 ` Junio C Hamano
2017-04-24 20:03 ` Stefan Beller
2017-04-24 22:11 ` Ramsay Jones
2017-04-24 22:17 ` Stefan Beller
2017-04-24 22:43 ` Ramsay Jones
2017-05-12 11:44 ` [GSoC][RFC/PATCH v3 1/2] t7407: test "submodule foreach --recursive" from subdirectory added Prathamesh Chavan
2017-05-12 11:44 ` [GSoC][RFC/PATCH v3 2/2] submodule: port subcommand foreach from shell to C Prathamesh Chavan
2017-05-15 17:22 ` Stefan Beller
2017-05-15 18:34 ` Brandon Williams
2017-05-21 12:58 ` [GSoC][PATCH v4 1/2] t7407: test "submodule foreach --recursive" from subdirectory added Prathamesh Chavan
2017-05-21 12:58 ` [GSoC][PATCH v4 2/2] submodule: port subcommand foreach from shell to C Prathamesh Chavan
2017-05-22 20:04 ` Stefan Beller
2017-05-23 19:09 ` Brandon Williams
2017-05-23 19:36 ` Brandon Williams
2017-05-23 20:57 ` Stefan Beller
2017-05-23 21:05 ` Brandon Williams
2017-05-26 15:17 ` [GSoC][PATCH v5 1/3] submodule: fix buggy $path and $sm_path variable's value Prathamesh Chavan
2017-05-26 15:17 ` [GSoC][PATCH v5 2/3] t7407: test "submodule foreach --recursive" from subdirectory added Prathamesh Chavan
2017-05-26 16:19 ` Stefan Beller
2017-05-26 16:33 ` Brandon Williams
2017-05-26 15:17 ` [GSoC][PATCH v5 3/3] submodule: port subcommand foreach from shell to C Prathamesh Chavan
2017-05-26 16:14 ` Stefan Beller
2017-05-26 16:44 ` Brandon Williams
2017-05-26 21:54 ` Johannes Sixt
2017-05-26 22:03 ` Brandon Williams
2017-05-27 1:20 ` Ramsay Jones
2017-05-27 14:06 ` Ramsay Jones
2017-05-27 21:24 ` Johannes Sixt [this message]
2017-05-26 16:31 ` [GSoC][PATCH v5 1/3] submodule: fix buggy $path and $sm_path variable's value Ramsay Jones
2017-05-26 17:07 ` Stefan Beller
2017-05-27 1:10 ` Ramsay Jones
2017-05-30 21:53 ` Stefan Beller
2017-05-30 23:07 ` Ramsay Jones
2017-05-30 23:29 ` Stefan Beller
2017-05-31 0:13 ` Ramsay Jones
2017-05-31 0:48 ` Ramsay Jones
2017-06-02 11:24 ` [GSoC][PATCH v6 1/2] " Prathamesh Chavan
2017-06-02 11:24 ` [GSoC][PATCH v6 2/2] submodule: port subcommand foreach from shell to C Prathamesh Chavan
2017-06-03 2:13 ` Stefan Beller
2017-06-04 10:32 ` Prathamesh Chavan
2017-05-23 19:06 ` [GSoC][PATCH v4 1/2] t7407: test "submodule foreach --recursive" from subdirectory added Brandon Williams
2017-06-03 0:37 ` [PATCH] submodule foreach: correct $sm_path in nested submodules from a dir Stefan Beller
2017-06-03 14:07 ` Ramsay Jones
2017-06-04 15:05 ` Ramsay Jones
2017-06-05 22:20 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ba646ee-ca8a-f8c1-3ba2-2a108852c98e@kdbg.org \
--to=j6t@kdbg.org \
--cc=bmwill@google.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pc44800@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).