From: Rasmus Villemoes <firstname.lastname@example.org> To: Git Mailing List <email@example.com> Cc: "Jeff King" <firstname.lastname@example.org>, "Stefan Beller" <email@example.com>, "Nguyễn Thái Ngọc Duy" <firstname.lastname@example.org> Subject: approximate_object_count_valid never set? Date: Thu, 17 Sep 2020 10:20:03 +0200 [thread overview] Message-ID: <email@example.com> (raw) Hi, While poking around the code, I noticed that it seems ->approximate_object_count_valid is never set to 1, and it never has been, not even back when it was a global variable. So perhaps it can just be removed and the logic depending on it simplified? Or am I missing some preprocessor trickery. Nobody seems to have noticed the lack of caching - and actually setting it to 1 after the count has been computed might be a little dangerous unless one takes care to invalidate the cache anywhere that might be relevant. Rasmus
next reply other threads:[~2020-09-17 8:20 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-17 8:20 Rasmus Villemoes [this message] 2020-09-17 11:58 ` Ævar Arnfjörð Bjarmason 2020-09-17 12:53 ` Jeff King 2020-09-17 16:47 ` [PATCH] packfile: actually set approximate_object_count_valid Jeff King 2020-09-17 16:53 ` Taylor Blau 2020-09-17 18:26 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: approximate_object_count_valid never set?' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).