From: Johannes Sixt <j.sixt@viscovery.net>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2012, #06; Wed, 23)
Date: Thu, 24 May 2012 07:59:02 +0200 [thread overview]
Message-ID: <4FBDCE26.1080904@viscovery.net> (raw)
In-Reply-To: <4FBDC8FA.9050501@lsrfire.ath.cx>
Am 5/24/2012 7:36, schrieb René Scharfe:
> Am 24.05.2012 00:24, schrieb Junio C Hamano:
>> * rs/maint-grep-F (2012-05-21) 4 commits
>> (merged to 'next' on 2012-05-23 at b24143c)
>> + grep: stop leaking line strings with -f
>> + grep: support newline separated pattern list
>> + grep: factor out do_append_grep_pat()
>> + grep: factor out create_grep_pat()
>>
>> "git grep -F", unlike the case where it reads from a file, did not treat
>> individual lines in the given pattern argument as separate patterns as it
>> should.
>
> This is not specific to -F; grep(1) accepts newline-separated pattern
> lists with -E etc. as well, as does git grep with the patches above.
Shouldn't we worry that this change breaks existing users?
Consider a script that generates a pattern that sometimes contains NL.
Yes, it would not match anywhere, but what if that is a deliberate choice
of the script writer? With this change, the script would now observe
spurious matches where earlier there were no matches.
-- Hannes
next prev parent reply other threads:[~2012-05-24 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 22:24 What's cooking in git.git (May 2012, #06; Wed, 23) Junio C Hamano
2012-05-24 5:36 ` René Scharfe
2012-05-24 5:59 ` Johannes Sixt [this message]
2012-05-24 17:01 ` Junio C Hamano
2012-05-24 16:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBDCE26.1080904@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).