From: Jens Lehmann <Jens.Lehmann@web.de>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/2] submodule: fix handling of supermodules with relative origin URLs
Date: Sun, 20 May 2012 02:34:04 +0200 [thread overview]
Message-ID: <4FB83BFC.4000702@web.de> (raw)
In-Reply-To: <CAH3AnrrqiXqdHHGZPyOPJ3Zend5JrQX0rKV+pz_mjs3SDjv9DA@mail.gmail.com>
Am 20.05.2012 00:51, schrieb Jon Seymour:
> On Sun, May 20, 2012 at 4:56 AM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
>> Am 19.05.2012 06:40, schrieb Jon Seymour:
>>
>> Just a small nit: I'd prefer to replace the 4 occurrences of the term
>> "supermodule" with "superproject".
>
> Sure. I can't argue with precedent, of course, but I guess I was
> favouring the consistency in the suffixes used with sub and super.
No big deal, but in recent posts "superproject" has been used and
the similarity between "supermodule" and "submodule" fooled me when
I read your RFC patch. So even though a superproject might be the a
submodule of another superproject, I'm all for using the term
"superproject" to make the distinction obvious.
>> So no objection on the code changes from my side.
>
> I noticed one relative case that is not handled properly yet, but
> there is a workaround. If the superproject's origin URL is of the
> form: foo/bar (a case I actually have myself for reasons I can explain
> if you want me to), then the correct rule doesn't get matched by
> .*/*). The workaround is for the user to change foo/bar style origin
> URLs to ./foo/bar.
>
> Let me know if I should fix this case now too.
Me thinks that this is subject for a subsequent patch. Having the
URL of the superproject *below* the root directory of the
superproject seems like a rather odd case which warrants a fix of
its own ;-)
next prev parent reply other threads:[~2012-05-20 0:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 4:40 [PATCH 1/2] submodule: add tests for add,sync,init in presence of relative super origin URL Jon Seymour
2012-05-19 4:40 ` [PATCH 2/2] submodule: fix handling of supermodules with relative origin URLs Jon Seymour
2012-05-19 18:56 ` Jens Lehmann
2012-05-19 22:51 ` Jon Seymour
2012-05-19 23:10 ` Jon Seymour
2012-05-19 23:45 ` Jon Seymour
2012-05-20 0:34 ` Jens Lehmann [this message]
2012-05-20 1:25 ` Jon Seymour
2012-05-20 5:16 ` Junio C Hamano
2012-05-20 13:28 ` [PATCH] Consistently use "superproject" instead of "supermodule" Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB83BFC.4000702@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).