From: Johannes Sixt <j6t@kdbg.org>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>,
Shezan Baig <shezbaig.wk@gmail.com>
Subject: Re: [PATCH] rebase -i: avoid checking out $branch when possible
Date: Fri, 20 Apr 2012 18:45:34 +0200 [thread overview]
Message-ID: <4F9192AE.5050304@kdbg.org> (raw)
In-Reply-To: <fee3225e29915e1b61e29a5d2fe37db20fa4b596.1334933837.git.trast@student.ethz.ch>
Am 20.04.2012 17:05, schrieb Thomas Rast:
> The command
>
> git rebase [-i] [--onto $onto] $base $branch
>
> is defined to be equivalent to
>
> git checkout $branch && git rebase [-i] [--onto $onto] $base
>
> However, we do not have to actually perform the checkout. The rebase
> starts building on top of $base (or $onto, if given). The tree
> _state_ (not diff) of $branch is irrelevant. Actually performing the
> checkout has some downsides: $branch may potentially be way out of
> touch with HEAD, and thus e.g. trigger a full rebuild in a timestamp-
> based build system, even if $base..$branch only edits the README.
Thanks, this is very much appreciated. I like it (because it would
prevent lots of unneeded rebuilds in my use-cases).
> cp "$todo" "$todo".backup
> git_sequence_editor "$todo" ||
> - die_abort "Could not execute editor"
> + die_abort_with_checkout "Could not execute editor"
I don't think that we want to checkout here, even if the docs say we do.
-- Hannes
prev parent reply other threads:[~2012-04-20 16:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 15:05 [PATCH] rebase -i: avoid checking out $branch when possible Thomas Rast
2012-04-20 15:52 ` Junio C Hamano
2012-04-20 16:01 ` Thomas Rast
2012-04-20 20:06 ` Junio C Hamano
2012-05-15 16:26 ` Shezan Baig
2012-05-15 17:08 ` Junio C Hamano
2012-05-18 8:27 ` Thomas Rast
2012-05-18 15:25 ` Junio C Hamano
2012-04-20 16:45 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9192AE.5050304@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=shezbaig.wk@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).