git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Antony Male <antony.male@gmail.com>,
	Phil Hord <phil.hord@gmail.com>, Johannes Sixt <j6t@kdbg.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	msysGit Mailinglist <msysgit@googlegroups.com>
Subject: [PATCH v3 0/4] submodules: Use relative paths to gitdir and work tree
Date: Sun, 04 Mar 2012 22:11:49 +0100	[thread overview]
Message-ID: <4F53DA95.2020402@web.de> (raw)

This is the third round of the former two patch series. It applies
cleanly on current master and maint and IMO is maint stuff as it fixes
bugs related to submodules. Those were introduced when moving the git
directory into that of the superproject and using a gitfile instead.

The first patch is unchanged from version one, in the second I did
address the concerns raised about the while loop. Those two patches
make superprojects movable again.

The third patch started as a mere refactoring, but while working on
it I noticed it also fixes an issue when submodules are moved around
inside a superproject.

The forth patch is provided by Johannes Sixt and addresses the issue
that under windows both POSIX and Windows style paths may occur which
sometimes broke the computation of relative paths.

Now all issues I'm aware of are fixed and tested for. In the next step
I'll be looking into teaching git mv to handle submodules, as just
mv'ing them someplace else, upating .gitmodules and adding the paths
isn't sufficient anymore. The core.worktree setting - and sometimes the
gitfile too (when the submodule is moved to a different directory level)
- have to be updated too to make that work (That would be easier if git
could treat the directory a gitfile was found in as a candidate for the
work tree, as then we could get rid of the core.worktree setting, but
we don't have that functionality).

Jens Lehmann (4):
  submodules: always use a relative path to gitdir
  submodules: always use a relative path from gitdir to work tree
  submodules: refactor computation of relative gitdir path
  submodules: fix ambiguous absolute paths under Windows

 git-submodule.sh            |   58 +++++++++++++++++++++----------------------
 t/t7400-submodule-basic.sh  |   22 ++++++++++++++++
 t/t7406-submodule-update.sh |   17 +++++++++++++
 3 files changed, 68 insertions(+), 29 deletions(-)

-- 
1.7.9.2.362.g684a8

             reply	other threads:[~2012-03-04 21:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-04 21:11 Jens Lehmann [this message]
2012-03-04 21:14 ` [PATCH v3 1/4] submodules: always use a relative path to gitdir Jens Lehmann
2012-03-04 21:15 ` [PATCH v3 2/4] submodules: always use a relative path from gitdir to work tree Jens Lehmann
2012-03-04 21:15 ` [PATCH v3 3/4] submodules: refactor computation of relative gitdir path Jens Lehmann
2012-03-04 21:16 ` [PATCH v3 4/4] submodules: fix ambiguous absolute paths under Windows Jens Lehmann
2012-03-07  6:31 ` [PATCH v3 0/4] submodules: Use relative paths to gitdir and work tree Junio C Hamano
2012-03-07 20:40   ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F53DA95.2020402@web.de \
    --to=jens.lehmann@web.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=antony.male@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=msysgit@googlegroups.com \
    --cc=phil.hord@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).