From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Junio C Hamano <gitster@pobox.com>
Cc: Thomas Rast <trast@inf.ethz.ch>,
git@vger.kernel.org, Bert Wesarg <bert.wesarg@googlemail.com>,
Geoffrey Irving <irving@naml.us>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Pierre Habouzit <madcoder@debian.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 4/3] parse-options: disallow --no-no-sth
Date: Wed, 29 Feb 2012 19:06:10 +0100 [thread overview]
Message-ID: <4F4E6912.7060204@lsrfire.ath.cx> (raw)
In-Reply-To: <7vlinmy80x.fsf@alter.siamese.dyndns.org>
Am 28.02.2012 22:15, schrieb Junio C Hamano:
> René Scharfe<rene.scharfe@lsrfire.ath.cx> writes:
>
>> Now that options whose definition starts with "no-" can be negated
>> by removing said "no-", there is no need anymore to allow them to
>> be negated by adding a second "no-", which just looks silly.
>
> Thanks. But accepting them silently and do what the user would have
> expected, especially if we do not advertise it, would not hurt anybody,
> no?
Yes, that's why I didn't include this fourth patch from the beginning.
However, I understood your comment "Among the existing 13 that you
listed, I do not think there is any that tempts any existing user to ask
for negation with "--no-no-foo" form, so I think we should be Ok." to
mean that nobody uses the double-no form of the existing negative
options anyway, and therefore we should disallow it.
Please drop this extra patch if I misunderstood you, in order to keep
backward compatibility.
René
next prev parent reply other threads:[~2012-02-29 18:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 19:07 [PATCH 0/3] parse-options: no- symmetry René Scharfe
2012-02-25 19:11 ` [PATCH 1/3] test-parse-options: convert to OPT_BOOL() René Scharfe
2012-02-25 19:14 ` [PATCH 2/3] parse-options: allow positivation of options starting, with no- René Scharfe
2012-02-26 23:32 ` Junio C Hamano
2012-02-27 8:30 ` Thomas Rast
2012-02-27 17:18 ` Junio C Hamano
2012-02-27 17:56 ` René Scharfe
2012-02-27 20:48 ` Junio C Hamano
2012-02-28 20:12 ` [PATCH 4/3] parse-options: disallow --no-no-sth René Scharfe
2012-02-28 21:15 ` Junio C Hamano
2012-02-29 18:06 ` René Scharfe [this message]
2012-02-29 19:02 ` Junio C Hamano
2012-02-25 19:15 ` [PATCH 3/3] parse-options: remove PARSE_OPT_NEGHELP René Scharfe
2012-02-27 18:25 ` Jeff King
2012-02-27 18:58 ` Junio C Hamano
2012-02-27 22:26 ` René Scharfe
2012-02-28 0:34 ` Jeff King
2012-02-28 19:06 ` [PATCH 3/3 v2] " René Scharfe
2012-02-28 19:09 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4E6912.7060204@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=Johannes.Schindelin@gmx.de \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=irving@naml.us \
--cc=madcoder@debian.org \
--cc=peff@peff.net \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).