From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 2C3411F953 for ; Thu, 6 Jan 2022 21:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244251AbiAFVcL (ORCPT ); Thu, 6 Jan 2022 16:32:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239110AbiAFVcK (ORCPT ); Thu, 6 Jan 2022 16:32:10 -0500 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ACC8C061245 for ; Thu, 6 Jan 2022 13:32:10 -0800 (PST) Received: by mail-qv1-xf2d.google.com with SMTP id kj16so3652993qvb.2 for ; Thu, 06 Jan 2022 13:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NgPFKM56cUfbCZE4VUFqGRxOVJsw73bz0F3nl0IrIyc=; b=YbcIzKJxITY3TBXMwtB6vgLKudf7pjdQ7J6BQpDlF1hJEdL6mkMj2mCTAIDzIONwrr tiJToHRTnYZIn9ZFlYPGaQ7cvUuJM1Fhlz2yMMzF8xFiaU+SN+p/T3Dk6Q4s+PWV3B61 8r4F3LTrNMwbPO9t0L8VdEkOCRwS5bxOEts6NDrfMS9xkRKzx+o70kQWRjgfD1rBGdzf cxpH6JI0KGCG3zoVr0iOZvHwJm6AraAp0fPLQNhCo8IWj80/1yW0CID+ICd8QWjjZew1 zneRwS8FLNGDrLUHMdqJv8EtY5UhaspNl8rTTHWfgRF8Gsqrwf5dJkNFPRoJgu3PmHz2 QWFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NgPFKM56cUfbCZE4VUFqGRxOVJsw73bz0F3nl0IrIyc=; b=hb9xcYyJPRL2RDRnCPxTPBc6vMeL9Fm8VqlAOcwj8DCsihsVwnx9+WBHB405DrZSKU q4iV+zTSZgZS2pJ6VT88XTHGE1ioyJRGd73+i0iEeQvKwmeVg35D3cwPvzbp6sAHxiBR ROmji+mbm6enrfmT6luKs0xlAJe+lfMVS6SGA+CxWv908Xvah4XLZpjYxtdhnkD9rvtr XYMCqNQZEzeVWIKlSAFd89/a0nci2aK01apldZLV0gKJg6vt5x0lTfWvQ16DCn6JrLP/ /yal7RU2pdOMav+pj+stf4ou9837NgzVe+QyL3dyBWftlPDKcDFV+nEhaUZkufAr4wdf /pdg== X-Gm-Message-State: AOAM53244nJMXE76fYVglLaSXcU29pTL6onHoQAheJCaNolPAYRiakGg mRxUrbdvAGMq9sWiYdt42UEyZr5/C2gBsg== X-Google-Smtp-Source: ABdhPJznwYOxfXMeZpucCDoHsqcWzt+7jo/38LxKagU6H1KdNk3ZryCbSUH7bdHlcU3dwTCMY+UzCw== X-Received: by 2002:a05:6214:19ca:: with SMTP id j10mr2832181qvc.5.1641504729403; Thu, 06 Jan 2022 13:32:09 -0800 (PST) Received: from [192.168.1.211] (pool-108-35-55-112.nwrknj.fios.verizon.net. [108.35.55.112]) by smtp.gmail.com with ESMTPSA id z14sm2492167qtw.59.2022.01.06.13.32.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jan 2022 13:32:08 -0800 (PST) From: John Cai To: Junio C Hamano Cc: John Cai via GitGitGadget , git@vger.kernel.org, =?utf-8?q?Ren=C3=A9?= Scharfe Subject: Re: [PATCH v5] builtin/reflog.c: use parse-options api for expire, delete subcommands Date: Thu, 06 Jan 2022 16:32:08 -0500 X-Mailer: MailMate Trial (1.14r5852) Message-ID: <4F3BFC1C-99A4-41E4-A32F-286F1287374A@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 6 Jan 2022, at 16:09, Junio C Hamano wrote: > "John Cai via GitGitGadget" writes: > >> From: John Cai >> >> Switching out manual arg parsing for the parse-options API for the >> expire and delete subcommands. >> >> Move explicit_expiry flag into cmd_reflog_expire_cb struct so callback= s >> can set both the value of the timestamp as well as the explicit_expiry= >> flag. >> >> Signed-off-by: "John Cai" >> --- > > Thanks. Will queue. > >> @@ builtin/reflog.c: static void set_reflog_expiry_param(struct c= md_reflog_expire_c >> + const struct option options[] =3D { >> + OPT_BIT(0, "dry-run", &flags, N_("do not actually prune any e= ntries"), >> + EXPIRE_REFLOGS_DRY_RUN), >> -+ OPT_BIT(0, "rewrite", &flags, >> ++ OPT_BIT(0, "rewrite", &flags, >> + N_("rewrite the old SHA1 with the new SHA1 of the entry that= now precedes it"), > > I think this change is a fat-finger; will correct while queuing. Oops, yes. Thanks for that and helping me through the review process :)