From: "Joel C. Salomon" <joelcsalomon@gmail.com>
To: kusmabite@gmail.com
Cc: "Jeff King" <peff@peff.net>,
"Git Mailing List" <git@vger.kernel.org>,
msysGit <msysgit@googlegroups.com>,
"Ævar Arnfjörð" <avarab@gmail.com>
Subject: Re: Breakage in master?
Date: Fri, 03 Feb 2012 08:55:37 -0500 [thread overview]
Message-ID: <4F2BE759.4000902@gmail.com> (raw)
In-Reply-To: <CABPQNSZfKCTsuusPpHa2djEOeGVN9z5s_Fr+S3EaHiv7Q4Re9w@mail.gmail.com>
On 02/03/2012 07:28 AM, Erik Faye-Lund wrote:
> On Thu, Feb 2, 2012 at 6:46 PM, Jeff King <peff@peff.net> wrote:
>> vsnprintf should generally never be returning -1 (it should return the
>> number of characters that would have been written). Since you're on
>> Windows, I assume you're using the replacement version in
>> compat/snprintf.c.
>
> No. SNPRINTF_RETURNS_BOGUS is only set for the MSVC target, not for
> the MinGW target. I'm assuming that means MinGW-runtime has a sane
> vsnprintf implementation.
That doesn't sound right; MinGW defaults to linking to a fairly old
version of the Windows C library (MSVCRT.dll from Visual Studio 6,
IIRC). According to <http://mingw.org/wiki/C99> there exists libmingwex
with some functions (especially those from <stdio.h>) replaced for
Standard compatibility, but it's "far from complete". (Is msysGit using
it anyway?)
--Joel
next prev parent reply other threads:[~2012-02-03 13:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 12:14 Breakage in master? Erik Faye-Lund
2012-02-02 17:46 ` Jeff King
2012-02-03 12:28 ` Erik Faye-Lund
2012-02-03 13:55 ` Joel C. Salomon [this message]
2012-02-03 14:05 ` Erik Faye-Lund
2012-02-03 14:22 ` Joel C. Salomon
2012-02-04 21:55 ` Erik Faye-Lund
2012-02-05 14:46 ` Fwd: " Erik Faye-Lund
2012-02-02 18:57 ` [msysGit] " Johannes Schindelin
2012-02-02 20:15 ` Torsten Bögershausen
2012-02-02 20:45 ` Johannes Sixt
2012-02-09 6:03 ` svnpenn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2BE759.4000902@gmail.com \
--to=joelcsalomon@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).