* Re: [PATCH] Add options to specify snapshot file name, prefix
[not found] <1320298641-11149-1-git-send-email-dermoth@aei.ca>
@ 2011-11-03 6:28 ` Thomas Guyot-Sionnest
0 siblings, 0 replies; only message in thread
From: Thomas Guyot-Sionnest @ 2011-11-03 6:28 UTC (permalink / raw
To: Thomas Guyot-Sionnest; +Cc: git
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Please disregard; i've actually managed to break the patch while playing
with it.
I will resubmit.
- --
Thomas
On 11-11-03 01:37 AM, Thomas Guyot-Sionnest wrote:
> commit b629275 implemented "smart" snapshot names and prefixes. I have
> scripts that used to rely on the old behaviour which allowed in some
> cases to have fixed prefix, and would require modifications to work with
> newer Gitweb.
>
> This patch adds two parameters for overriding the snapshot name and
> prefix, sn and sp respectively. For example, to get a snapshot
> named "myproject.[suffix]" with no prefix one can add this query string:
> ?sn=myproject;sp=
>
> Signed-off-by: Thomas Guyot-Sionnest <dermoth@aei.ca>
> ---
> gitweb/gitweb.perl | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 4f0c3bd..4820ef7 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -756,6 +756,8 @@ our @cgi_param_mapping = (
> searchtext => "s",
> searchtype => "st",
> snapshot_format => "sf",
> + snapshot_name => "sn",
> + snapshot_prefix => "sp",
> extra_options => "opt",
> search_use_regexp => "sr",
> ctag => "by_tag",
> @@ -6684,6 +6686,12 @@ sub git_snapshot {
> }
>
> my ($name, $prefix) = snapshot_name($project, $hash);
> + if (defined($input_params{'snapshot_name'})) {
> + $name = $input_params{'snapshot_name'};
> + }
> + if (defined($input_params{'snapshot_prefix'})) {
> + $prefix = $input_params{'snapshot_prefix'};
> + }
> my $filename = "$name$known_snapshot_formats{$format}{'suffix'}";
> my $cmd = quote_command(
> git_cmd(), 'archive',
- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk6yNJcACgkQ6dZ+Kt5BchZkCgCgvJ9kAF636HYCAwQ7LoWu8ckG
8+8Anj5ocii3c7vKQ2/eVjcAvDJxsvhQ
=jGwr
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-11-03 6:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1320298641-11149-1-git-send-email-dermoth@aei.ca>
2011-11-03 6:28 ` [PATCH] Add options to specify snapshot file name, prefix Thomas Guyot-Sionnest
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).