From: Michael J Gruber <git@drmicha.warpmail.net>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Conrad Irwin <conrad.irwin@gmail.com>,
Sitaram Chamarty <sitaramc@gmail.com>
Subject: Re: [PATCH] rev-parse: Allow @{U} as a synonym for @{u}
Date: Thu, 18 Aug 2011 11:31:33 +0200 [thread overview]
Message-ID: <4E4CDBF5.4040709@drmicha.warpmail.net> (raw)
In-Reply-To: <CACsJy8Dr5q=h-9MhNV0gKtVEn13+DxWwcNn2Prem6-+DyrDmHA@mail.gmail.com>
Nguyen Thai Ngoc Duy venit, vidit, dixit 18.08.2011 10:54:
> On Thu, Aug 18, 2011 at 2:15 PM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> For a german keyboard layout, you get @{u} from
>>
>> hold AltGr (Meta)
>> press q
>> press 7
>> release AltGr
>> press u
>> hold AltGr
>> press 0
>>
>> For me, an improvement would be to have the alias
>>
>> @{↓}
>
> While it's convenient to type, the output now looks strange. If you do
> a screencast, or someone is watching you, they may not understand what
> that syntax is.
just like with any shell or git alias.
>
> Also..
>
>> As a simpler case, a user could tailor to her keyboard layout with
>>
>> git config revalias.↓ u
>
> We may also have encoding issue here. What if config file is in utf-8,
> but the console is not?
It's a user setting, tailored for the user's environment.
> So I don't we should go this way. There may be a better way to deal
> with different keyboard layouts.
>
>> Well, this patch is actually specific to a particular keyboard layout!
>> It improves things only for a layout where you get @ and { using a shift
>> key.
>
> Fully agreed. While it does not help non en-US keyboards, it does not
> cause any harm (jealousy is not classified as harm to me, rather
> motivation ;).
If you sell it as
"rev key is like a config key, so make it case insensitive. As a side
effect, it helps certain keyboard layouts and does not harm others."
it may fair a better chance ;)
I guess this should apply to rev^{<type>} as well, then.
Michael
next prev parent reply other threads:[~2011-08-18 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 7:57 can we have @{U} as an alias for @{u} Sitaram Chamarty
2011-08-14 1:57 ` [PATCH] rev-parse: Allow @{U} as a synonym " Conrad Irwin
2011-08-17 22:53 ` Junio C Hamano
2011-08-18 1:53 ` Nguyen Thai Ngoc Duy
2011-08-18 7:15 ` Michael J Gruber
2011-08-18 8:54 ` Nguyen Thai Ngoc Duy
2011-08-18 9:31 ` Michael J Gruber [this message]
2011-08-19 18:54 ` Conrad Irwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4CDBF5.4040709@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=conrad.irwin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=sitaramc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).