From: "Frédéric Heitzmann" <frederic.heitzmann@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git svn : hook before 'git svn dcommit'
Date: Mon, 04 Jul 2011 07:54:19 +0200 [thread overview]
Message-ID: <4E11558B.90708@gmail.com> (raw)
In-Reply-To: <vpq62njaxl2.fsf@bauges.imag.fr>
Le 03/07/2011 23:00, Matthieu Moy a écrit :
> Frédéric Heitzmann<frederic.heitzmann@gmail.com> writes:
>
>> The 'pre-svn-dcommit' hook is called by 'git svn dcommit' and can be used to
>> prevent some diff to be committed to a SVN repository. It may typically be
>> used to filter some intermediate patches, which were committed into git but
>> must not find their way to the SVN repository.
> Why 2 patches?
>
> We usually try to have each commit as correct as possible (e.g. when
> sending several patches, each commit should still pass the testsuite).
> With your 2-patches serie, the first commit has documentation for a
> feature which doesn't exist yet.
I find it easier to separate commits on documentation from code patch,
especially for rereading and dicussing.
However, if it is desirable to get them merged, I could do that easily.
As for the order :
patch 1/2 : perl magic
patch 2/2 : documentation update
=> the serie looks in the right order to me.
next prev parent reply other threads:[~2011-07-04 5:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 12:48 [PATCH] git svn : hook before 'git svn dcommit' Frédéric Heitzmann
2011-07-02 13:54 ` Matthieu Moy
2011-07-02 17:25 ` Frédéric Heitzmann
2011-07-02 21:59 ` Matthieu Moy
2011-07-03 20:49 ` Frédéric Heitzmann
2011-07-03 20:49 ` [PATCH 1/2] " Frédéric Heitzmann
2011-07-03 20:49 ` [PATCH 2/2] git svn : documentation of 'pre-svn-dcommit' Frédéric Heitzmann
2011-07-03 21:00 ` [PATCH] git svn : hook before 'git svn dcommit' Matthieu Moy
2011-07-04 5:54 ` Frédéric Heitzmann [this message]
2011-07-05 20:44 ` [PATCH v2] " Frédéric Heitzmann
2011-07-09 12:18 ` Frédéric Heitzmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E11558B.90708@gmail.com \
--to=frederic.heitzmann@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).