From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Stephen Boyd <bebarino@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 0/9] Some more sparse patches
Date: Mon, 11 Apr 2011 19:21:13 +0100 [thread overview]
Message-ID: <4DA34699.5080200@ramsay1.demon.co.uk> (raw)
In-Reply-To: <4D9EB61B.6010302@gmail.com>
Stephen Boyd wrote:
> Yeah I was sitting on a few of these since I didn't have the time or
> effort to sort them out. Plus I have to wade through all the warnings
> that ULONG_MAX and LONG_MAX causes on my 64 bit system causing me to
> miss some things. Thanks for picking it up.
I've been thinking of getting a new laptop soon; when I do, I'll have to
face this myself. Until then I'm firmly in 32-bit land, so I'm afraid
that I can't help :-(
> I pulled these patches down and gave them a test. It looks good to me,
> except I see this when I check http.c:
>
> $ make http.sp
> SP http.c
> builtin:1:9: warning: preprocessor token GIT_HTTP_USER_AGENT redefined
> builtin:1:9: this was the original definition
>
> Any ideas?
Hmm, sorry no. I'm not seeing this on any of my platforms. On Linux and
Cygwin sparse is silent, and on MinGW (which has NO_CURL defined BTW) I
see a few legitimate warnings, thus:
$ make http.sp
SP http.c
http.c:806:25: warning: expression using sizeof on a function
http.c:815:25: warning: expression using sizeof on a function
http.c:1139:9: warning: expression using sizeof on a function
http.c:1303:9: warning: expression using sizeof on a function
Again, these warnings are legit (they relate to an insane "inline"
optimization macro which uses sizeof on a function pointer).
ATB,
Ramsay Jones
prev parent reply other threads:[~2011-04-11 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 18:16 [PATCH 0/9] Some more sparse patches Ramsay Jones
2011-04-08 7:15 ` Stephen Boyd
2011-04-11 18:21 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA34699.5080200@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).