From: Michael J Gruber <git@drmicha.warpmail.net>
To: "\"Alejandro R. Sedeño\"" <asedeno@MIT.EDU>
Cc: git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>,
James Y Knight <jknight@itasoftware.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] git-svn: Add a svn-remote.<name>.pushurl config key
Date: Wed, 06 Apr 2011 17:38:37 +0200 [thread overview]
Message-ID: <4D9C88FD.5080807@drmicha.warpmail.net> (raw)
In-Reply-To: <4D9C8803.1000708@mit.edu>
"Alejandro R. Sedeño" venit, vidit, dixit 06.04.2011 17:34:
> On 04/06/2011 11:22 AM, Michael J Gruber wrote:
>> Alejandro R. Sedeño venit, vidit, dixit 06.04.2011 17:05:
>>> Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
>>> Reviewed-off-by: James Y Knight <jknight@itasoftware.com>
>>
>> :) So, if that review is off, that means...
>
> Um, s/-off//. Oops :)
>
> I can send a follow-up, or let Eric deal with that change, however he prefers.
>
>>> diff --git a/git-svn.perl b/git-svn.perl
>>> index fa8cd07..184442a 100755
>>> --- a/git-svn.perl
>>> +++ b/git-svn.perl
>>> @@ -531,7 +531,7 @@ sub cmd_dcommit {
>>> $url = eval { command_oneline('config', '--get',
>>> "svn-remote.$gs->{repo_id}.commiturl") };
>>> if (!$url) {
>>> - $url = $gs->full_url
>>> + $url = $gs->full_pushurl
>>
>> Wouldn't we want to do the same $gs->full_pushurl || $gs->full_url fall
>> back here as below, or is fullpush_url always set? OK, I see it always is.
>
> Yeah, I just went with full_pushurl returning full_url in cases where
> pushurl is not set.
>
>>> @@ -2071,6 +2073,8 @@ sub new {
>>> $self->{url} = command_oneline('config', '--get',
>>> "svn-remote.$repo_id.url") or
>>> die "Failed to read \"svn-remote.$repo_id.url\" in config\n";
>>> + $self->{pushurl} = eval { command_oneline('config', '--get',
>>> + "svn-remote.$repo_id.pushurl") };
>>
>> Why eval? We don't do it for url either.
>
> Because otherwise it would die with:
>
> $ git svn fetch
> config --get svn-remote.svn.pushurl: command returned error: 1
>
> when pushurl wasn't defined. If that happens with 'url' too, well, that's
> a mis-configured git-svn remote.
>
>>> +sub full_pushurl {
>>> + my ($self) = @_;
>>
>> Isn't that a noop?
>
> I'm just copying the style of sub full_url here.
>
OK, I finally understood the reason for "eval" and "my ($self) = @_;". I
simply shouldn't look at perl code ;)
Thanks!
Michael
next prev parent reply other threads:[~2011-04-06 15:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 19:09 [PATCHv2 0/2] a couple of git-svn patches Alejandro R. Sedeño
2011-04-04 19:09 ` [PATCH 1/2] git-svn: Fix the commit-url config to be the base url, just like the url config Alejandro R. Sedeño
2011-04-04 21:52 ` Eric Wong
2011-04-04 22:16 ` James Y Knight
2011-04-04 22:54 ` Eric Wong
2011-04-05 15:11 ` "Alejandro R. Sedeño"
2011-04-05 20:15 ` [PATCH] git-svn: Add a svn-remote.<name>.pushurl config key Alejandro R. Sedeño
2011-04-05 20:25 ` "Alejandro R. Sedeño"
2011-04-05 21:09 ` Eric Wong
2011-04-06 12:53 ` Michael J Gruber
2011-04-06 13:04 ` "Alejandro R. Sedeño"
2011-04-06 13:12 ` Michael J Gruber
2011-04-06 15:05 ` Alejandro R. Sedeño
2011-04-06 15:22 ` Michael J Gruber
2011-04-06 15:34 ` "Alejandro R. Sedeño"
2011-04-06 15:38 ` Michael J Gruber [this message]
2011-04-08 14:57 ` Alejandro R. Sedeño
2011-04-08 20:13 ` Junio C Hamano
2011-04-08 20:25 ` Michael J Gruber
2011-04-08 20:54 ` Jeff King
[not found] ` <7v4o6830cc.fsf@alter.siamese.dyndns.org>
2011-04-08 21:32 ` Jeff King
2011-04-08 22:25 ` Junio C Hamano
2011-04-08 22:40 ` Jeff King
2011-04-08 22:43 ` Jeff King
2011-04-22 19:11 ` "Alejandro R. Sedeño"
2011-04-22 19:36 ` Jeff King
2011-04-22 19:40 ` "Alejandro R. Sedeño"
2011-04-09 22:47 ` Eric Wong
2011-04-06 12:44 ` Michael J Gruber
2011-04-06 12:56 ` "Alejandro R. Sedeño"
2011-04-04 19:09 ` [PATCH 2/2] git-svn: Cache results of running the executable "git config" Alejandro R. Sedeño
2011-04-04 21:53 ` Eric Wong
[not found] ` <7voc4l5hm5.fsf@alter.siamese.dyndns.org>
2011-04-05 8:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9C88FD.5080807@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=asedeno@MIT.EDU \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jknight@itasoftware.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).