Re: [RFC/PATCH 3/3] builtin/show.c: do not prune by pathspec

[Michael J Gruber <git@drmicha.warpmail.net>]

Nguyen Thai Ngoc Duy venit, vidit, dixit 31.03.2011 14:50:
> I suggest add "commit" to the subject: do not prune commit by
> pathspec. Diff limiting is another kind of pruning and I was confused.

I know that under the name "diff limiting" only (that may be my ignorance).

> 
> On Thu, Mar 31, 2011 at 4:17 PM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> By design, "git show commit -- path" is not "git show commit:path", and
>> there is no reason to change that.
> 
> Even more true, now that "path" can be "*.sh".
> 
>> But "git show commit -- path" simply
>> returns nothing at all "most of the time" because it prunes by pathspec
>> even though it does not walk commits. This is pretty useless.
>>
>> So, turn off pruning (but keep diff limiting of course) so that "git
>> show commit -- path" shows the commit message and the diff that the
>> commit introduces to path (filtered by path); only the diff will be
>> empty "most of the time".
> 
> Tests please?

Heck, we don't have any to begin with, and this is marked RFC. Given our
usual reluctance to change even undocumented behavior I'm not going to
bother with tests for an RFC.

>> As an intended side effect, users mistaking "git show commit -- path"
>> for "git show commit:path" are automatically reminded that they asked
>> git to show a commit, not a blob.
> 
> Nor a tree. I don't really see how "git show commit:path" and "git how
> commit -- path" are relevant for it to be mentioned here.

"git show commit:path" is relevant because that is what the OP was
trying to do, and "git show commit:path" is relevant because that is
what the OP tried and confused him because there was no output at all.
Not to mention that this is the command this patch is about.

Someone needs a coffee, me thinks ;)

Michael