From: Michael J Gruber <git@drmicha.warpmail.net>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCHv3 2/2] git-patch-id: do not trip over "no newline" markers
Date: Fri, 18 Feb 2011 11:43:16 +0100 [thread overview]
Message-ID: <4D5E4D44.6000203@drmicha.warpmail.net> (raw)
In-Reply-To: <20110218104151.GB7262@sigill.intra.peff.net>
Jeff King venit, vidit, dixit 18.02.2011 11:41:
> On Fri, Feb 18, 2011 at 11:12:42AM +0100, Michael J Gruber wrote:
>
>> Currently, patch-id trips over the diff extension for marking
>> the absence of newline at EOF.
>>
>> Fix it. (Ignore it, it's whitespace.)
>>
>> This uses the same detection rationale as in buitlin/apply.c, which was
>> introduced in
>>
>> 433ef8a ([PATCH] Make git-apply understand incomplete lines in non-C locales, 2005-09-04)
>
> Thanks, this looks good to me, with one style nit:
>
>> + else if (!memcmp(line, "\\ ", 2) && strlen(line)>=12)
>> + continue;
>
> Whitespace around relational operators.
You think
+ else if (!memcmp(line, "\\ ", 2)&&strlen(line)>=12)
is that much better?
Nitpickers need to brace for smartass responses ;)
Junio, should I resend with two extra spaces?
Michael
next prev parent reply other threads:[~2011-02-18 10:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 14:56 Why does git-patch-id(1) sometimes print two lines, one of which has commit = 0000000000000000000000000000000000000000 Ævar Arnfjörð Bjarmason
2011-02-16 16:11 ` Michael J Gruber
2011-02-16 16:55 ` [PATCH 1/2] git-patch-id: test for "no newline" markers Michael J Gruber
2011-02-16 16:55 ` [PATCH 2/2] git-patch-id: do not trip over " Michael J Gruber
2011-02-16 20:05 ` Junio C Hamano
2011-02-17 7:44 ` [PATCHv2 1/2] git-patch-id: test for " Michael J Gruber
2011-02-17 7:44 ` [PATCHv2 2/2] git-patch-id: do not trip over " Michael J Gruber
2011-02-18 4:16 ` Jeff King
2011-02-18 8:02 ` Michael J Gruber
2011-02-18 10:12 ` [PATCHv3 1/2] git-patch-id: test for " Michael J Gruber
2011-02-18 10:12 ` [PATCHv3 2/2] git-patch-id: do not trip over " Michael J Gruber
2011-02-18 10:41 ` Jeff King
2011-02-18 10:43 ` Michael J Gruber [this message]
2011-02-18 10:47 ` Jeff King
2011-02-18 14:29 ` Jakub Narebski
2011-02-18 10:40 ` [PATCHv2 " Jeff King
2011-02-17 11:55 ` [PATCHv2 1/2] git-patch-id: test for " Jakub Narebski
2011-02-17 12:11 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5E4D44.6000203@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).