From: Johannes Sixt <j.sixt@viscovery.net>
To: Tilman Vogel <tilman.vogel@web.de>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-gui: add config value gui.diffopts for passing additional diff options
Date: Fri, 28 Jan 2011 08:29:02 +0100 [thread overview]
Message-ID: <4D42703E.5070202@viscovery.net> (raw)
In-Reply-To: <4D420B95.2060509@web.de>
Am 1/28/2011 1:19, schrieb Tilman Vogel:
> Am 25.01.2011 01:25, schrieb Pat Thoyts:
>> This seems ok but you don't say what it is for. Why do you want to be
>> able to pass additional options to git diff?
>
> Sorry, forgot to copy the motivation from
> <https://github.com/git/git/pull/8>:
>
> I want to be able to make diff ignore whitespace changes "-b". But maybe
> someone else wants "-w" or what not, so I think a generic option field
> is most versatile.
What do you expect to happen, when a user writes any of the following in
that edit box?
--name-status
-R
--frotz
origin master
Don't you want to diagnose bogus input?
Disable "Stage/Unstage hung/lines" (because they won't apply anymore)?
Etc.
I don't think this is a great improvement. At the least it is not thought
through.
-- Hannes
prev parent reply other threads:[~2011-01-28 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 10:59 [PATCH] git-gui: add config value gui.diffopts for passing additional diff options Tilman Vogel
2011-01-25 0:25 ` Pat Thoyts
2011-01-28 0:19 ` Tilman Vogel
2011-01-28 7:29 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D42703E.5070202@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
--cc=tilman.vogel@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).