git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j6t@kdbg.org>, GIT Mailing-list <git@vger.kernel.org>
Subject: [PATCH 0/14] misc msvc patches
Date: Sat, 04 Dec 2010 18:49:49 +0000	[thread overview]
Message-ID: <4CFA8D4D.2020500@ramsay1.demon.co.uk> (raw)

Hi Junio,

The msvc build of git.git is currently broken; these patches fix
the build and suppress most of the *many* compiler warnings.
[These patches are based on master @ 94fdb6f from 2 days ago]

[PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c
[PATCH 02/14] msvc: git-daemon.exe: Fix linker "unresolved externals" error
[PATCH 03/14] msvc: Fix build by adding missing INTMAX_MAX define

These patches actually fix the build. Note that I haven't actually tested
git-daemon.exe, but it should behave exactly the same as the MinGW build
(famous last words).

[PATCH 04/14] msvc: Fix macro redefinition warnings

Prior to this patch, the msvc build spews 1184 warnings. After this patch,
the warning count is down to 176! :-P

[PATCH 05/14] run-command.c: Initialise variable to suppress msvc warnings
[PATCH 06/14] match-trees.c: Initialise variables to suppress msvc warnings
[PATCH 07/14] fast-import.c: Initialise variables to suppress msvc warnings
[PATCH 08/14] submodule.c: Initialise variables to suppress msvc warnings
[PATCH 09/14] merge-recursive.c: Initialise variable to suppress msvc warning
[PATCH 10/14] fast-export.c: Initialise variable to suppress msvc warning
[PATCH 11/14] cat-file.c: Initialise variable to suppress msvc warning
[PATCH 12/14] rev-list.c: Initialise variables to suppress msvc warnings
[PATCH 13/14] transport.c: Initialise variable to suppress msvc warning
[PATCH 14/14] wt-status.c: Initialise variable to suppress msvc warning

These patches were originally a single patch, since they all implement the
same fix, and could be squashed back into a single commit.  However, I
decided to split it up by file to make it easier to review. Note that the
warnings here are issued by the linker, since we have requested link-time
code generation, which explains why the one-liner in patch 5 fixes 26
warnings (start_command() is linked into 26 executables). These patches
reduce the warning count to 126.

[The remaining 126 warnings are all very similar, see an up-coming RFC series]

ATB,
Ramsay Jones

                 reply	other threads:[~2010-12-04 20:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CFA8D4D.2020500@ramsay1.demon.co.uk \
    --to=ramsay@ramsay1.demon.co.uk \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).