From: Jens Lehmann <Jens.Lehmann@web.de>
To: Git Mailing List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Kevin Ballard <kevin@sb.org>,
Jon Seymour <jon.seymour@gmail.com>,
Chris Packham <judge.packham@gmail.com>,
Marc Branchaud <marcnarc@xiplink.com>
Subject: [PATCH v3 0/3] Teach fetch and pull to recursively fetch submodules
Date: Thu, 11 Nov 2010 00:53:07 +0100 [thread overview]
Message-ID: <4CDB3063.5010801@web.de> (raw)
So here is the third iteration of the recursive fetch/pull series.
Changes since v2:
* The default now is to not recurse into submodules (also see "Still
to do")
* The command line option has been renamed to "--recurse-submodules" as
proposed at the GitTogether
* The config options are named "submodule.<name>.fetchRecurseSubmodules"
and "fetch.recurseSubmodules" now
* Switched the order of the two patches adding the config options
Question:
* Should the "--submodule-prefix" option - which is only used internally
now - be a hidden option to "git fetch"?
Still to do:
* Add a mode to only fetch those submodules where new recorded commits
are fetched in the superproject (and maybe later even fetch only those
commits in the submodule which are referenced in the superprojects
fetch). This could be a sane default - especially for projects having
lots of submodules - and could be enabled by using then to be added
"--recurse-submodules=changed" and "fetch[.]recurseSubmodules=changed"
options where the configuration uses other defaults (I'm not really
convinced yet 'changed' is a very good name but couldn't come up with
a better one yet. So suggestions for alternatives are very welcome :-)
* Boost performance by concurrently fetching submodules (after my first
experiments this must be configurable, e.g. how many fetch commands
to run at the same time, as some git servers barf on too many fetches
run at the same time)
But nonetheless I think this patch series is ok for inclusion as it does
not change default behavior and gives people the opportunity to play with
recursive fetch/pull by enabling one of the introduced config options.
Jens Lehmann (3):
fetch/pull: Add the --recurse-submodules option
Add the 'fetch.recurseSubmodules' config setting
Submodules: Add the "fetchRecurseSubmodules" config option
Documentation/config.txt | 12 +++
Documentation/fetch-options.txt | 13 +++
Documentation/gitmodules.txt | 8 ++
builtin/fetch.c | 64 ++++++++++---
git-pull.sh | 10 ++-
submodule.c | 98 +++++++++++++++++++-
submodule.h | 5 +
t/t5526-fetch-submodules.sh | 195 +++++++++++++++++++++++++++++++++++++++
8 files changed, 388 insertions(+), 17 deletions(-)
create mode 100755 t/t5526-fetch-submodules.sh
--
1.7.3.2.337.g9376c
next reply other threads:[~2010-11-10 23:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 23:53 Jens Lehmann [this message]
2010-11-10 23:54 ` [PATCH v3 1/3] fetch/pull: Add the --recurse-submodules option Jens Lehmann
2010-11-10 23:55 ` [PATCH v3 2/3] Add the 'fetch.recurseSubmodules' config setting Jens Lehmann
2010-11-11 0:02 ` Jonathan Nieder
2010-11-11 8:14 ` Jens Lehmann
2010-11-11 8:27 ` Jonathan Nieder
2010-11-11 18:31 ` Junio C Hamano
2010-11-11 19:00 ` Jonathan Nieder
2010-11-12 11:54 ` Jens Lehmann
2010-11-12 15:52 ` Jonathan Nieder
2010-11-12 19:48 ` Jens Lehmann
2010-11-12 20:16 ` Jonathan Nieder
2010-11-12 21:58 ` Jens Lehmann
2010-11-12 11:40 ` Jens Lehmann
2010-11-10 23:55 ` [PATCH v3 3/3] Submodules: Add the "fetchRecurseSubmodules" config option Jens Lehmann
2010-11-11 0:05 ` [PATCH v3 0/3] Teach fetch and pull to recursively fetch submodules Jonathan Nieder
2010-11-11 8:18 ` Jens Lehmann
2010-11-12 12:54 ` [PATCH v4 1/3] fetch/pull: Add the --recurse-submodules option Jens Lehmann
2010-11-12 19:54 ` Jonathan Nieder
2010-11-12 20:22 ` Jens Lehmann
2010-12-09 21:16 ` Junio C Hamano
2010-12-09 23:07 ` Jens Lehmann
2010-12-10 17:30 ` Junio C Hamano
2010-12-10 18:03 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDB3063.5010801@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jon.seymour@gmail.com \
--cc=judge.packham@gmail.com \
--cc=kevin@sb.org \
--cc=marcnarc@xiplink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).