git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Stephan Hugel <urschrei@gmail.com>
Subject: Re: [PATCH 1/5] t/t7004-tag: test handling of rfc1991 signatures
Date: Wed, 10 Nov 2010 09:23:59 +0100	[thread overview]
Message-ID: <4CDA569F.5090901@drmicha.warpmail.net> (raw)
In-Reply-To: <7vhbfqjaho.fsf@alter.siamese.dyndns.org>

Junio C Hamano venit, vidit, dixit 10.11.2010 01:19:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>> The --rfc1991 option matters for the creation of signatures only, not
>> for the verification (and neither for display/listing with git, of course).
> 
> Doesn't the above statement assume a bit too much about how the current
> version of gpg behaves, I have to wonder?

[Note: I'm sick and may sound even more grumpy than usual...]

* This test (and the patches) is about making signed tags work for
people with rfc1991 in their options. This is why I put rfc1991 in gpg's
option file.

Note that git always produced rfc1991 sigs for those users, and always
failed to verify/list them properly, no matter what gpg option is active
during the verify/list phase.

* If you /also/ want to test that users without --rfc1991 can very those
rfc1991 sigs one would need an additional test after the "rm...". I'm
telling you that --rfc1991 is completely irrelevant for what gpg
accepts, and thus the additional test is completely superfluous. gpg is
lenient about what it accepts (within existing rfc's) and strict about
what it produces (according to what you tell it to do), just like it
should. This is by design and intentional, not version dependent or by
chance. (Even requesting strict openpgp mode does not change this.)

So, the rm needs to stay where it is.

I could repeat the three tests again after the rm, albeit in different
order so that the first one has no chance of rewriting the rfc1991 sig
into an openpgp sig. I have no objection against that, it does no good
and no harm.

Michael

  reply	other threads:[~2010-11-10  8:26 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04 22:13 Error when verifying tags signed using 1.7.3.1 Stephan Hugel
2010-10-04 22:51 ` Daniel Johnson
2010-10-04 23:04   ` Stephan Hugel
2010-10-04 23:59     ` Daniel Johnson
2010-10-05  0:17       ` Stephan Hugel
2010-10-05  8:00         ` Michael J Gruber
2010-10-05 13:28           ` Stephan Hugel
2010-10-05 15:07             ` Michael J Gruber
2010-10-05 15:19               ` Stephan Hugel
2010-10-05 15:39                 ` Michael J Gruber
2010-10-05 15:40                   ` [PATCH] tag,verify-tag: do not trip over rfc1991 signatures Michael J Gruber
2010-10-05 20:28                     ` Junio C Hamano
2010-10-05 20:42                       ` Michael J Gruber
2010-10-05 20:51                         ` Stephan Hugel
2010-10-05 20:56                           ` Michael J Gruber
2010-11-06 11:04                             ` [PATCH 0/5] Handling of " Michael J Gruber
2010-11-06 11:04                               ` [PATCH 1/5] t/t7004-tag: test handling " Michael J Gruber
2010-11-09 17:17                                 ` Junio C Hamano
2010-11-09 17:23                                   ` Michael J Gruber
2010-11-10  0:19                                     ` Junio C Hamano
2010-11-10  8:23                                       ` Michael J Gruber [this message]
2010-11-06 11:04                               ` [PATCH 2/5] verify-tag: factor out signature detection Michael J Gruber
2010-11-06 17:40                                 ` Thiago Farina
2010-11-06 11:04                               ` [PATCH 3/5] tag: factor out sig detection for body edits Michael J Gruber
2010-11-06 11:04                               ` [PATCH 4/5] tag: factor out sig detection for tag display Michael J Gruber
2010-11-06 11:04                               ` [PATCH 5/5] tag: recognize rfc1991 signatures Michael J Gruber
2010-11-06 17:46                                 ` Thiago Farina
2010-11-08 19:27                                   ` Junio C Hamano
2010-11-10 11:17                               ` [PATCHv2 0/5] Handling of " Michael J Gruber
2010-11-10 11:17                                 ` [PATCHv2 1/5] t/t7004-tag: test handling " Michael J Gruber
2010-11-10 11:17                                 ` [PATCHv2 2/5] verify-tag: factor out signature detection Michael J Gruber
2010-11-10 11:17                                 ` [PATCHv2 3/5] tag: factor out sig detection for body edits Michael J Gruber
2010-11-10 11:17                                 ` [PATCHv2 4/5] tag: factor out sig detection for tag display Michael J Gruber
2010-11-10 11:17                                 ` [PATCHv2 5/5] tag: recognize rfc1991 signatures Michael J Gruber
2010-11-10 17:41                                 ` [PATCHv2 0/5] Handling of " Junio C Hamano
2010-10-05 20:42                     ` [PATCH] tag,verify-tag: do not trip over " Todd Zullinger
2010-10-05 20:47                       ` Michael J Gruber
2010-10-05 15:45                   ` Error when verifying tags signed using 1.7.3.1 Stephan Hugel
2010-10-05  9:41       ` Pat Thoyts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CDA569F.5090901@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=urschrei@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).