From: Peter Harris <pharris@opentext.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, msysgit@googlegroups.com,
sschuberth@gmail.com
Subject: Re: [PULL] Pull request from msysGit
Date: Thu, 07 Oct 2010 15:30:46 -0400 [thread overview]
Message-ID: <4CAE1FE6.9020306@opentext.com> (raw)
In-Reply-To: <4CAE00C5.1050509@ramsay1.demon.co.uk>
On 2010-10-07 13:17, Ramsay Jones wrote:
> Now, Peter Harris has already submitted a fix for this, which is
> currently on the work/msvc-fixes branch, which contains:
>
> 358f1be Modify MSVC wrapper script
> 38bd27d Fix MSVC build
>
> The suggested fix is given in commit 38bd27d. However, I prefer a
> different solution, which is given below:
>
> --- >8 ---
> diff --git a/compat/mingw.h b/compat/mingw.h
> index afedf3a..445d1a1 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -12,12 +12,6 @@ typedef int pid_t;
> #define S_ISLNK(x) (((x) & S_IFMT) == S_IFLNK)
> #define S_ISSOCK(x) 0
>
> -#ifndef _STAT_H_
> -#define S_IRUSR 0
> -#define S_IWUSR 0
> -#define S_IXUSR 0
> -#define S_IRWXU (S_IRUSR | S_IWUSR | S_IXUSR)
> -#endif
> #define S_IRGRP 0
> #define S_IWGRP 0
> #define S_IXGRP 0
> --- 8< ---
>
> Note that, for *both* MinGW and MSVC, the deleted #defines
> are not wanted, pointless and just plain wrong! :-D
I didn't realize that the defines were not wanted for MinGW either.
I heartily approve of removing code rather than just ifdefing around it.
Please use this version of the patch instead of mine.
Peter Harris
--
Open Text Connectivity Solutions Group
Peter Harris http://connectivity.opentext.com/
Research and Development Phone: +1 905 762 6001
pharris@opentext.com Toll Free: 1 877 359 4866
next prev parent reply other threads:[~2010-10-07 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 23:52 [PULL] Pull request from msysGit Pat Thoyts
2010-10-05 16:45 ` Junio C Hamano
2010-10-07 17:17 ` Ramsay Jones
2010-10-07 19:30 ` Peter Harris [this message]
2010-10-07 20:18 ` [msysGit] " Pat Thoyts
2010-10-07 20:22 ` Erik Faye-Lund
2010-10-09 17:56 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAE1FE6.9020306@opentext.com \
--to=pharris@opentext.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@users.sourceforge.net \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).