t9155 fails since "git-svn: fix fetch with deleted tag" with svn < 1.5

t9155 fails since "git-svn: fix fetch with deleted tag" with svn < 1.5

[Jens Lehmann]

t9155 fails on current next when running the testsuite on a Fedora
Core 7 system. The reason is that FC7 comes with svn 1.4.4, while
in commit 3235b70 the --parents option was introduced into t9155
which was added in svn 1.5.

What minimum svn version is required for git svn? I didn't find any
information about that, but I might have overlooked something ...

Re: t9155 fails since "git-svn: fix fetch with deleted tag" with svn < 1.5

[Ævar Arnfjörð Bjarmason]

On Thu, Aug 19, 2010 at 16:57, Jens Lehmann <Jens.Lehmann@web.de> wrote:
> t9155 fails on current next when running the testsuite on a Fedora
> Core 7 system. The reason is that FC7 comes with svn 1.4.4, while
> in commit 3235b70 the --parents option was introduced into t9155
> which was added in svn 1.5.
>
> What minimum svn version is required for git svn? I didn't find any
> information about that, but I might have overlooked something ...

We currently require >= 1.1.0 of SVN::Core for the git-svn tests at least.

Re: t9155 fails since "git-svn: fix fetch with deleted tag" with svn < 1.5

[Eric Wong]

Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> On Thu, Aug 19, 2010 at 16:57, Jens Lehmann <Jens.Lehmann@web.de> wrote:
> > t9155 fails on current next when running the testsuite on a Fedora
> > Core 7 system. The reason is that FC7 comes with svn 1.4.4, while
> > in commit 3235b70 the --parents option was introduced into t9155
> > which was added in svn 1.5.

The --parents option appears completely unnecessary in this case,
so removing it should be safe.  Patch coming...

> > What minimum svn version is required for git svn? I didn't find any
> > information about that, but I might have overlooked something ...
> 
> We currently require >= 1.1.0 of SVN::Core for the git-svn tests at least.

That's still the only hard requirement I know of.  While I haven't had a
1.1.x installation in years, reports of incompatibility have been few.
So either people find it easier to upgrade to newer versions of SVN,
don't care, or there just aren't that many incompatibilities.

I'd say we will continue to do our best to support whatever versions
people care to report (preferably with patches :) incompatibilities for.

-- 
Eric Wong

[PATCH] t9155: fix compatibility with older SVN

[Eric Wong]

The "--parents" option did not appear until SVN 1.5.x
and is completely unnecessary in this case.

Reported-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---

 Also pushed up to git://git.bogomips.org/git-svn

 t/t9155-git-svn-fetch-deleted-tag.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/t/t9155-git-svn-fetch-deleted-tag.sh b/t/t9155-git-svn-fetch-deleted-tag.sh
index ef0ac87..a486a98 100755
--- a/t/t9155-git-svn-fetch-deleted-tag.sh
+++ b/t/t9155-git-svn-fetch-deleted-tag.sh
@@ -12,7 +12,7 @@ test_expect_success 'setup svn repo' '
 	svn_cmd import -m "import for git svn" import "$svnrepo" &&
 	rm -rf import &&
 
-	svn_cmd mkdir --parents -m "create mybranch directory" "$svnrepo/branches/mybranch" &&
+	svn_cmd mkdir -m "create mybranch directory" "$svnrepo/branches/mybranch" &&
 	svn_cmd cp -m "create branch mybranch" "$svnrepo/trunk" "$svnrepo/branches/mybranch/trunk" &&
 
 	svn_cmd co "$svnrepo/trunk" svn_project &&
-- 
Eric Wong

Re: [PATCH] t9155: fix compatibility with older SVN

[David D. Kilzer]

On Thu, August 19, 2010 at 12:15:52 PM, Eric Wong wrote:


> The "--parents" option did not appear until SVN 1.5.x
> and is completely  unnecessary in this case.


At one point in development, I wasn't creating the branches directory on the 
initial import, which is why this was added.  Thanks for fixing this!

> Reported-by: Jens Lehmann <Jens.Lehmann@web.de>
> Signed-off-by:  Eric Wong <normalperson@yhbt.net>


Ack.

Dave

Re: [PATCH] t9155: fix compatibility with older SVN

[Jens Lehmann]

Am 19.08.2010 21:15, schrieb Eric Wong:
> The "--parents" option did not appear until SVN 1.5.x
> and is completely unnecessary in this case.

Thanks for the quick response! I'll test this patch on Monday when
I have access to that FC7 machine again.

Re: [PATCH] t9155: fix compatibility with older SVN

[Jens Lehmann]

Am 19.08.2010 21:40, schrieb Jens Lehmann:
> Am 19.08.2010 21:15, schrieb Eric Wong:
>> The "--parents" option did not appear until SVN 1.5.x
>> and is completely unnecessary in this case.
> 
> Thanks for the quick response! I'll test this patch on Monday when
> I have access to that FC7 machine again.

Just for the record:

Tested-By: Jens Lehmann <Jens.Lehmann@web.de>