git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v2] test-lib: Multi-prereq support only checked the last prereq
Date: Fri, 13 Aug 2010 22:28:40 +0200	[thread overview]
Message-ID: <4C65AAF8.80009@kdbg.org> (raw)
In-Reply-To: <1281528278-15659-1-git-send-email-avarab@gmail.com>

Am 11.08.2010 14:04, schrieb Ævar Arnfjörð Bjarmason:
> -		say_color skip "ok $test_count # skip $1 (prereqs: $prereq)"
> +		say_color skip "ok $test_count # skip $1 (missing $missing_prereq of $prereq)"

This needs fixing: When a test is skipped due to being listed in 
GIT_SKIP_TESTS, then the output looks like this:

ok 47 # skip --ignore-submodules=untracked suppresses submodules with 
untracked content (missing SANITY,POSIXPERM of )

(In this case, there was a test before number 47 that was skipped due to 
missing prerequisite.)

Please also note that - when a prerequisite is not satisfied - the text in 
parentheses does not say "prerequisite" or similar anymore. IMO, this 
should be added back.

-- Hannes

  reply	other threads:[~2010-08-13 20:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-10 23:21 [PATCH] test-lib: Multi-prereq support only checked the last prereq Ævar Arnfjörð Bjarmason
2010-08-11  1:43 ` Jonathan Nieder
2010-08-11 12:04   ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-08-13 20:28     ` Johannes Sixt [this message]
2010-08-24  7:34     ` [PATCH] tests: simplify "missing PREREQ" message Jonathan Nieder
2010-08-24 10:16       ` Johannes Sixt
2010-08-24 19:01       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C65AAF8.80009@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).