git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Kirill Smelkov <kirr@mns.spb.ru>
Cc: Paul Mackerras <paulus@samba.org>, git@vger.kernel.org
Subject: Re: [PATCH] gitk: Show notes
Date: Tue, 11 May 2010 16:35:45 +0200	[thread overview]
Message-ID: <4BE96B41.7010902@drmicha.warpmail.net> (raw)
In-Reply-To: <1273566416-3512-1-git-send-email-kirr@mns.spb.ru>

Kirill Smelkov venit, vidit, dixit 11.05.2010 10:26:
> If in git.git I do
> 
>     $ git notes add -m 'This makes status significantly slower with Dokko' \
>         ee6fc514
> 
> then `git log` shows the note...
> 

because --show-notes is the default...

> ... but unfortunately gitk does not.

... unless --pretty is given, and gitk uses --pretty.

But what is wrong with gitk --show-notes?

If you mean to adjust gitk's default to log's current default please say
so in the commit message. There's no need to include a longish sample
output for that.

Also, I don't think proc do_readcommit needs the notes. The other two
places use $args, so it might make sense to prepend --show-notes to the
arg list in a central place.

Michael

  reply	other threads:[~2010-05-11 14:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11  8:26 [PATCH] gitk: Show notes Kirill Smelkov
2010-05-11 14:35 ` Michael J Gruber [this message]
2010-05-12  8:56   ` Kirill Smelkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE96B41.7010902@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=kirr@mns.spb.ru \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).