Can cc's be included in patches sent by send-email

Can cc's be included in patches sent by send-email

[Philip Oakley]

While 'git send-email' can have multiple --cc="addressee" options on the 
command line, is it possible for the "cc:addressee<a@b.c>" to actually be 
included in the patches that are to be sent, so that different patches can 
have different addressee?

The fortmat-patch can include appropriate from lines, so it feels as if the 
sender should be able to add cc: lines at the same place. Maybe its just 
part of th docs I've missed.

This is for the workflow where the patch series (including cover letter) is 
reviewed before send-email is invoked to send to all adressees.

--
Philip 

Re: Can cc's be included in patches sent by send-email

[Jacob Keller]

On Thu, Aug 11, 2016 at 12:32 AM, Philip Oakley <philipoakley@iee.org> wrote:
> While 'git send-email' can have multiple --cc="addressee" options on the
> command line, is it possible for the "cc:addressee<a@b.c>" to actually be
> included in the patches that are to be sent, so that different patches can
> have different addressee?
>
> The fortmat-patch can include appropriate from lines, so it feels as if the
> sender should be able to add cc: lines at the same place. Maybe its just
> part of th docs I've missed.
>

Yes, just put them in the body as tags below the signed-off-by. It
should be on by default unless you change supresscc or signedoffbycc
configuration.

Thanks,
Jake

> This is for the workflow where the patch series (including cover letter) is
> reviewed before send-email is invoked to send to all adressees.
>
> --
> Philip
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Can cc's be included in patches sent by send-email

[Jacob Keller]

On Thu, Aug 11, 2016 at 12:58 AM, Jacob Keller <jacob.keller@gmail.com> wrote:
> On Thu, Aug 11, 2016 at 12:32 AM, Philip Oakley <philipoakley@iee.org> wrote:
>> While 'git send-email' can have multiple --cc="addressee" options on the
>> command line, is it possible for the "cc:addressee<a@b.c>" to actually be
>> included in the patches that are to be sent, so that different patches can
>> have different addressee?
>>
>> The fortmat-patch can include appropriate from lines, so it feels as if the
>> sender should be able to add cc: lines at the same place. Maybe its just
>> part of th docs I've missed.
>>
>
> Yes, just put them in the body as tags below the signed-off-by. It
> should be on by default unless you change supresscc or signedoffbycc
> configuration.
>
> Thanks,
> Jake
>

See --suppress-cc or --signed-off-by-cc help in git help send-email.

Thanks,
Jake

Re: Can cc's be included in patches sent by send-email

[Junio C Hamano]

Jacob Keller <jacob.keller@gmail.com> writes:

> On Thu, Aug 11, 2016 at 12:58 AM, Jacob Keller <jacob.keller@gmail.com> wrote:
>> On Thu, Aug 11, 2016 at 12:32 AM, Philip Oakley <philipoakley@iee.org> wrote:
>>> While 'git send-email' can have multiple --cc="addressee" options on the
>>> command line, is it possible for the "cc:addressee<a@b.c>" to actually be
>>> included in the patches that are to be sent, so that different patches can
>>> have different addressee?
>>>
>>> The fortmat-patch can include appropriate from lines, so it feels as if the
>>> sender should be able to add cc: lines at the same place. Maybe its just
>>> part of th docs I've missed.
>>>
>>
>> Yes, just put them in the body as tags below the signed-off-by. It
>> should be on by default unless you change supresscc or signedoffbycc
>> configuration.
>>
>> Thanks,
>> Jake
>>
>
> See --suppress-cc or --signed-off-by-cc help in git help send-email.

Also, those who do not want to see Cc: in headers (like me) can
instead edit the header part of the format-patch output to add Cc:
lines and they should be picked up.

Re: Can cc's be included in patches sent by send-email

[Junio C Hamano]

On Thu, Aug 11, 2016 at 10:57 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
> Also, those who do not want to see Cc: in headers (like me) can

Stupid typo that ruins the whole message.  I meant "in FOOTERS".

> instead edit the header part of the format-patch output to add Cc:
> lines and they should be picked up.

Re: Can cc's be included in patches sent by send-email

[Philip Oakley]

From: "Jacob Keller" <jacob.keller@gmail.com>
> On Thu, Aug 11, 2016 at 12:58 AM, Jacob Keller <jacob.keller@gmail.com> 
> wrote:
>> On Thu, Aug 11, 2016 at 12:32 AM, Philip Oakley <philipoakley@iee.org> 
>> wrote:
>>> While 'git send-email' can have multiple --cc="addressee" options on the
>>> command line, is it possible for the "cc:addressee<a@b.c>" to actually 
>>> be
>>> included in the patches that are to be sent, so that different patches 
>>> can
>>> have different addressee?
>>>
>>> The fortmat-patch can include appropriate from lines, so it feels as if 
>>> the
>>> sender should be able to add cc: lines at the same place. Maybe its just
>>> part of th docs I've missed.
>>>
>>
>> Yes, just put them in the body as tags below the signed-off-by. It
>> should be on by default unless you change supresscc or signedoffbycc
>> configuration.
>>
>> Thanks,
>> Jake
>>
>
> See --suppress-cc or --signed-off-by-cc help in git help send-email.
>
> Thanks,
> Jake

Thanks,
I'll look at that. It wasn't immediately obvious what to do.

Philip 

Re: Can cc's be included in patches sent by send-email

[Philip Oakley]

From: "Junio C Hamano" <gitster@pobox.com>
> Jacob Keller <jacob.keller@gmail.com> writes:
>
>> On Thu, Aug 11, 2016 at 12:58 AM, Jacob Keller <jacob.keller@gmail.com> 
>> wrote:
>>> On Thu, Aug 11, 2016 at 12:32 AM, Philip Oakley <philipoakley@iee.org> 
>>> wrote:
>>>> While 'git send-email' can have multiple --cc="addressee" options on 
>>>> the
>>>> command line, is it possible for the "cc:addressee<a@b.c>" to actually 
>>>> be
>>>> included in the patches that are to be sent, so that different patches 
>>>> can
>>>> have different addressee?
>>>>
>>>> The fortmat-patch can include appropriate from lines, so it feels as if 
>>>> the
>>>> sender should be able to add cc: lines at the same place. Maybe its 
>>>> just
>>>> part of th docs I've missed.
>>>>
>>>
>>> Yes, just put them in the body as tags below the signed-off-by. It
>>> should be on by default unless you change supresscc or signedoffbycc
>>> configuration.
>>>
>>> Thanks,
>>> Jake
>>>
>>
>> See --suppress-cc or --signed-off-by-cc help in git help send-email.
>
> Also, those who do not want to see Cc: in headers (like me) can
> instead edit the header part of the format-patch output to add Cc:
> lines and they should be picked up.
> --
When done via git gui, it looks like the Cc: is also included in the commit 
message (first initial tries)

I'd probably place them after a --- break so that they don't get into the 
applied commit message, but will carry around during my rebasing. I've still 
to test if it works though.

Philip