* instaweb does not start because of a small syntax error in .git/gitweb/httpd.conf
@ 2009-07-18 15:08 Bodo Schlecht
2009-07-18 16:45 ` [PATCH] Trivial path quoting fixes in git-instaweb Sean Estabrooks
0 siblings, 1 reply; 3+ messages in thread
From: Bodo Schlecht @ 2009-07-18 15:08 UTC (permalink / raw
To: git
When I start instaweb with
git instaweb
I get this error:
Syntax error on line 8 of /media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/gitweb/httpd.conf:
TypesConfig takes one argument, the MIME types config file
Could not execute http daemon apache2 -f.
Line 8 of /.git/gitweb/httpd.conf reads
TypesConfig /media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/mime.types
As you see, there is a space in the path so it should be quotes:
TypesConfig "/media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/mime.types"
In all other lines of http.conf the path is correctly in quotes:
ServerName "git-instaweb"
ServerRoot "/media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/gitweb"
DocumentRoot "/media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/gitweb"
PidFile "/media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/pid"
Listen 127.0.0.1:4321
LoadModule mime_module /usr/lib/apache2/modules/mod_mime.so
LoadModule dir_module /usr/lib/apache2/modules/mod_dir.so
TypesConfig /media/disk1part4/Eigene Dateien/superdigi/superdigientwicklung/.git/mime.types
DirectoryIndex gitweb.cgi
LoadModule cgi_module /usr/lib/apache2/modules/mod_cgi.so
AddHandler cgi-script .cgi
<Location /gitweb.cgi>
Options +ExecCGI
</Location>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Trivial path quoting fixes in git-instaweb
2009-07-18 15:08 instaweb does not start because of a small syntax error in .git/gitweb/httpd.conf Bodo Schlecht
@ 2009-07-18 16:45 ` Sean Estabrooks
2009-07-26 10:10 ` Eric Wong
0 siblings, 1 reply; 3+ messages in thread
From: Sean Estabrooks @ 2009-07-18 16:45 UTC (permalink / raw
To: Bodo Schlecht; +Cc: git
Bodo Schlecht noticed that Instaweb didn't propely quote all
path instances in the Apache config file it generated.
---
git-instaweb.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 5f4419b..32f6496 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -256,7 +256,7 @@ apache2_conf () {
mkdir -p "$GIT_DIR/gitweb/logs"
bind=
test x"$local" = xtrue && bind='127.0.0.1:'
- echo 'text/css css' > $fqgitdir/mime.types
+ echo 'text/css css' > "$fqgitdir/mime.types"
cat > "$conf" <<EOF
ServerName "git-instaweb"
ServerRoot "$fqgitdir/gitweb"
@@ -272,7 +272,7 @@ EOF
fi
done
cat >> "$conf" <<EOF
-TypesConfig $fqgitdir/mime.types
+TypesConfig "$fqgitdir/mime.types"
DirectoryIndex gitweb.cgi
EOF
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Trivial path quoting fixes in git-instaweb
2009-07-18 16:45 ` [PATCH] Trivial path quoting fixes in git-instaweb Sean Estabrooks
@ 2009-07-26 10:10 ` Eric Wong
0 siblings, 0 replies; 3+ messages in thread
From: Eric Wong @ 2009-07-26 10:10 UTC (permalink / raw
To: Junio C Hamano; +Cc: Bodo Schlecht, git, Sean Estabrooks
Sean Estabrooks <seanlkml@sympatico.ca> wrote:
>
> Bodo Schlecht noticed that Instaweb didn't propely quote all
> path instances in the Apache config file it generated.
Works for me here, thank you.
Acked-by: Eric Wong <normalperson@yhbt.net>
> ---
> git-instaweb.sh | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/git-instaweb.sh b/git-instaweb.sh
> index 5f4419b..32f6496 100755
> --- a/git-instaweb.sh
> +++ b/git-instaweb.sh
> @@ -256,7 +256,7 @@ apache2_conf () {
> mkdir -p "$GIT_DIR/gitweb/logs"
> bind=
> test x"$local" = xtrue && bind='127.0.0.1:'
> - echo 'text/css css' > $fqgitdir/mime.types
> + echo 'text/css css' > "$fqgitdir/mime.types"
> cat > "$conf" <<EOF
> ServerName "git-instaweb"
> ServerRoot "$fqgitdir/gitweb"
> @@ -272,7 +272,7 @@ EOF
> fi
> done
> cat >> "$conf" <<EOF
> -TypesConfig $fqgitdir/mime.types
> +TypesConfig "$fqgitdir/mime.types"
> DirectoryIndex gitweb.cgi
> EOF
>
> --
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-26 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-18 15:08 instaweb does not start because of a small syntax error in .git/gitweb/httpd.conf Bodo Schlecht
2009-07-18 16:45 ` [PATCH] Trivial path quoting fixes in git-instaweb Sean Estabrooks
2009-07-26 10:10 ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).