git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Stephen Boyd <bebarino@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv2 2/2] parse-options: simplify usage argh handling
Date: Sat, 06 Jun 2009 12:30:19 +0200	[thread overview]
Message-ID: <4A2A453B.7060202@lsrfire.ath.cx> (raw)
In-Reply-To: <1244159037-9292-2-git-send-email-bebarino@gmail.com>

Stephen Boyd schrieb:
> Simplify the argh printing by simply calling usage_argh() if the option
> can take an argument. Update macros defined in parse-options.h to set
> the PARSE_OPT_NOARG flag.
> 
> The only other user of custom non-argument taking options is git-apply
> (in this case OPTION_BOOLEAN for deprecated options). Update it to set
> the PARSE_OPT_NOARG flag.
> 
> Thanks to René Scharfe for the suggestion and starter patch.
> 
> Signed-off-by: Stephen Boyd <bebarino@gmail.com>
> ---
> 
> René, feel free to signoff if you like.
> 
>  builtin-apply.c |    6 ++++--
>  parse-options.c |   33 ++++-----------------------------
>  parse-options.h |   20 +++++++++++++-------
>  3 files changed, 21 insertions(+), 38 deletions(-)

Looks good, thanks.  The output of this command:

	$ for c in ./git-*; do $c --help-all </dev/null; done

didn't change, except for git-send-email reporting a different temporary
file name (unrelated to this patch, of course).

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>

      reply	other threads:[~2009-06-06 10:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03  7:49 [PATCH] parse-options: make OPT_NUMBER's argh explicit Stephen Boyd
2009-06-03 10:18 ` René Scharfe
2009-06-03 19:35   ` Stephen Boyd
2009-06-03 20:22     ` René Scharfe
2009-06-04 23:43       ` [PATCHv2 1/2] parse-options: make OPT_INTEGER's " Stephen Boyd
2009-06-04 23:43         ` [PATCHv2 2/2] parse-options: simplify usage argh handling Stephen Boyd
2009-06-06 10:30           ` René Scharfe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2A453B.7060202@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).